Re: Crashes in next-20160915 (BUG at fs/notify/notification.c:66!)

From	Jan Kara <jack@suse.cz>
Newsgroups	linux.kernel
Subject	Re: Crashes in next-20160915 (BUG at fs/notify/notification.c:66!)
Date	2016-09-21 11:20 +0200
Message-ID	<sjLR8-78t-25@gated-at.bofh.it> (permalink)
References	(2 earlier) <shZlv-3Xl-21@gated-at.bofh.it> <si0Ui-4PI-1@gated-at.bofh.it> <sjhT3-4IM-9@gated-at.bofh.it> <sjhT3-4IM-7@gated-at.bofh.it> <sjs26-2Lm-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue 20-09-16 22:05:00, Michael Ellerman wrote:
> Andrew Morton <akpm@linux-foundation.org> writes:
> > On Tue, 20 Sep 2016 11:10:35 +1000 Michael Ellerman <mpe@ellerman.id.au> wrote:
> >> Jan Kara <jack@suse.cz> writes:
> >> >
> >> > Right, that was the problem. spin_is_locked() without CONFIG_SPINLOCK_DEBUG
> >> > returns always 0.
> >> 
> >> Can we get this fixed soon please? It's breaking all my CI runs.
> >
> > It should be fixed in next -next.
> 
> Great thanks.
> 
> I did search LKML to see if Jan had sent a fix but I guess I missed it.

I didn't send the fix to LKML but only to linux-fsdevel...

> > diff -puN fs/notify/fanotify/fanotify_user.c~fsnotify-convert-notification_mutex-to-a-spinlock-fix fs/notify/fanotify/fanotify_user.c
> > --- a/fs/notify/fanotify/fanotify_user.c~fsnotify-convert-notification_mutex-to-a-spinlock-fix
> > +++ a/fs/notify/fanotify/fanotify_user.c
> > @@ -54,7 +54,8 @@ struct kmem_cache *fanotify_perm_event_c
> >  static struct fsnotify_event *get_one_event(struct fsnotify_group *group,
> >  					    size_t count)
> >  {
> > -	BUG_ON(!spin_is_locked(&group->notification_lock));
> > +	BUG_ON(IS_ENABLED(CONFIG_SMP) &&
> > +	       !spin_is_locked(&group->notification_lock));
>   
> I thought lockdep_assert_held() was preferred for checks like this that
> are purely sanity checking, ie. not part of the algorithm.

As pointed out by other guy, assert_spin_locked() is probably the right way
to do it (it's a wrapper that does essentially what I did here). Somehow I
missed that when looking for the right fix.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Thread

Crashes in next-20160915 (BUG at fs/notify/notification.c:66!) Guenter Roeck <linux@roeck-us.net> - 2016-09-16 04:30 +0200
  Re: Crashes in next-20160915 (BUG at fs/notify/notification.c:66!) Jan Kara <jack@suse.cz> - 2016-09-16 11:20 +0200
    Re: Crashes in next-20160915 (BUG at fs/notify/notification.c:66!) Guenter Roeck <linux@roeck-us.net> - 2016-09-16 13:20 +0200
      Re: Crashes in next-20160915 (BUG at fs/notify/notification.c:66!) Jan Kara <jack@suse.cz> - 2016-09-16 15:00 +0200
        Re: Crashes in next-20160915 (BUG at fs/notify/notification.c:66!) Andrew Morton <akpm@linux-foundation.org> - 2016-09-20 03:20 +0200
          Re: Crashes in next-20160915 (BUG at fs/notify/notification.c:66!) Michael Ellerman <mpe@ellerman.id.au> - 2016-09-20 14:10 +0200
            Re: Crashes in next-20160915 (BUG at fs/notify/notification.c:66!) Jan Kara <jack@suse.cz> - 2016-09-21 11:20 +0200
        Re: Crashes in next-20160915 (BUG at fs/notify/notification.c:66!) Michael Ellerman <mpe@ellerman.id.au> - 2016-09-20 03:20 +0200

csiph-web