Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1487869

Re: [PATCH 5/9] dmaengine/ARM: omap-dma: Fix the DMAengine compile test on non OMAP configs

From Peter Ujfalusi <peter.ujfalusi@ti.com>
Newsgroups linux.kernel
Subject Re: [PATCH 5/9] dmaengine/ARM: omap-dma: Fix the DMAengine compile test on non OMAP configs
Date 2016-09-21 09:40 +0200
Message-ID <sjKim-64W-23@gated-at.bofh.it> (permalink)
References <shWQG-2fE-7@gated-at.bofh.it> <shWQG-2fE-5@gated-at.bofh.it> <sjGHM-3JI-13@gated-at.bofh.it> <sjGHM-3JI-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 09/21/16 06:53, Vinod Koul wrote:
> On Wed, Sep 21, 2016 at 09:21:32AM +0530, Vinod Koul wrote:
>> On Fri, Sep 16, 2016 at 11:33:20AM +0300, Peter Ujfalusi wrote:
>>> The DMAengine driver for omap-dma use three function calls from the
>>> plat-omap legacy driver. When the DMAengine driver is built when ARCH_OMAP
>>> is not set, the compilation will fail due to missing symbols.
>>> Add empty inline functions to allow the DMAengine driver to be compiled
>>> with COMPILE_TEST.
>>
>> Peter,
>>
>> This should be before you enable COMPILE_TEST otherwise build will break!
> 
> Ah never mind, you have three drivers in this series so I think this is fine
> before the omap one :)

Yep, patch 1-4 is for eDMA, patch 5-6 is for omap-dma and the remaining is for
ti-dma-crossbar.

I wanted to have them separate (including when I enable the COMPILE_TEST) so
we can revert easily if needed.

If I move the 'enable COMPILE_TEST' patches at the end of the series, I think
I will still have them as separate as they are enabling the test for three
different driver.

-- 
Péter

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 5/9] dmaengine/ARM: omap-dma: Fix the DMAengine compile test on non OMAP configs Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-09-16 10:40 +0200
  Re: [PATCH 5/9] dmaengine/ARM: omap-dma: Fix the DMAengine compile  test on non OMAP configs Vinod Koul <vinod.koul@intel.com> - 2016-09-21 05:50 +0200
    Re: [PATCH 5/9] dmaengine/ARM: omap-dma: Fix the DMAengine compile  test on non OMAP configs Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-09-21 09:40 +0200
  Re: [PATCH 5/9] dmaengine/ARM: omap-dma: Fix the DMAengine compile  test on non OMAP configs Vinod Koul <vinod.koul@intel.com> - 2016-09-21 05:50 +0200

csiph-web