Re: [PATCH] mm: migrate: Return false instead of -EAGAIN for dummy functions

From	Vlastimil Babka <vbabka@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm: migrate: Return false instead of -EAGAIN for dummy functions
Date	2016-09-21 10:20 +0200
Message-ID	<sjKV4-6zb-25@gated-at.bofh.it> (permalink)
References	(1 earlier) <siq2m-4k3-1@gated-at.bofh.it> <sjes9-2tY-21@gated-at.bofh.it> <sjohQ-lL-15@gated-at.bofh.it> <sjBoJ-tX-3@gated-at.bofh.it> <sjKV4-6zb-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/21/2016 10:11 AM, Michal Hocko wrote:
> On Wed 21-09-16 06:06:44, Chen Gang wrote:
>> On 9/20/16 16:09, Michal Hocko wrote:
> [...]
>
> skipping the large part of the email because I do not have a spare time
> to discuss this.
>
>>> So what is the point of this whole exercise? Do not take me wrong, this
>>> area could see some improvements but I believe that doing int->bool
>>> change is not just the right thing to do and worth spending both your
>>> and reviewers time.
>>>
>>
>> I am not quite sure about that.
>
> Maybe you should listen to the feedback your are getting. I do not think
> I am not the first one here.
>
> Look, MM surely needs some man power. There are issues to be solved,
> patches to review. Doing the cleanups is really nice but there are more
> serious problems to solve first. If you want to help then starting
> with review would be much much more helpful and hugely appreciated. We
> are really lacking people there a _lot_. Just generating more work for
> reviewers with something that doesn't make any real difference in the
> runtime is far less helpful IMHO.

Agreed, thanks.

> Thanks.
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mm: migrate: Return false instead of -EAGAIN for dummy functions chengang@emindsoft.com.cn - 2016-09-17 09:30 +0200
  Re: [PATCH] mm: migrate: Return false instead of -EAGAIN for dummy  functions Michal Hocko <mhocko@kernel.org> - 2016-09-17 17:50 +0200
    Re: [PATCH] mm: migrate: Return false instead of -EAGAIN for dummy  functions Chen Gang <chengang@emindsoft.com.cn> - 2016-09-19 23:40 +0200
      Re: [PATCH] mm: migrate: Return false instead of -EAGAIN for dummy  functions Michal Hocko <mhocko@kernel.org> - 2016-09-20 10:10 +0200
        Re: [PATCH] mm: migrate: Return false instead of -EAGAIN for dummy  functions Chen Gang <chengang@emindsoft.com.cn> - 2016-09-21 00:10 +0200
          Re: [PATCH] mm: migrate: Return false instead of -EAGAIN for dummy  functions Michal Hocko <mhocko@kernel.org> - 2016-09-21 10:20 +0200
            Re: [PATCH] mm: migrate: Return false instead of -EAGAIN for dummy  functions Vlastimil Babka <vbabka@suse.cz> - 2016-09-21 10:20 +0200

csiph-web