Re: [PATCH v3 1/5] clk: at91: move slow clock controller clocks to sckc.c

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/5] clk: at91: move slow clock controller clocks to sckc.c
Date	2016-09-21 10:10 +0200
Message-ID	<sjKLo-6u9-9@gated-at.bofh.it> (permalink)
References	<sjAj0-81b-3@gated-at.bofh.it> <sjAj0-81b-19@gated-at.bofh.it> <sjDgR-1Cv-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 20/09/2016 at 17:02:11 -0700, Stephen Boyd wrote :
> On 09/20, Alexandre Belloni wrote:
> > Move all clocks related to the slow clock controller to sckc.c. This avoids
> > extern definitions and allows to remove sckc.h
> > 
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > ---
> 
> Applied to clk-next
> 

Thanks for the fix!

> drivers/clk/at91/sckc.c:146:13:
> warning: symbol 'of_at91sam9x5_clk_slow_osc_setup' was not
> declared. Should it be static?
> drivers/clk/at91/sckc.c:260:13:
> warning: symbol 'of_at91sam9x5_clk_slow_rc_osc_setup' was not
> declared. Should it be static?
> drivers/clk/at91/sckc.c:359:13:
> warning: symbol 'of_at91sam9x5_clk_slow_setup' was not declared.
> Should it be static?
> 
> ----8<----
> diff --git a/drivers/clk/at91/sckc.c b/drivers/clk/at91/sckc.c
> index f6ed711af738..311956abf4aa 100644
> --- a/drivers/clk/at91/sckc.c
> +++ b/drivers/clk/at91/sckc.c
> @@ -143,8 +143,8 @@ at91_clk_register_slow_osc(void __iomem *sckcr,
>  	return hw;
>  }
>  
> -void __init of_at91sam9x5_clk_slow_osc_setup(struct device_node *np,
> -					     void __iomem *sckcr)
> +static void __init
> +of_at91sam9x5_clk_slow_osc_setup(struct device_node *np, void __iomem *sckcr)
>  {
>  	struct clk_hw *hw;
>  	const char *parent_name;
> @@ -257,8 +257,8 @@ at91_clk_register_slow_rc_osc(void __iomem *sckcr,
>  	return hw;
>  }
>  
> -void __init of_at91sam9x5_clk_slow_rc_osc_setup(struct device_node *np,
> -						void __iomem *sckcr)
> +static void __init
> +of_at91sam9x5_clk_slow_rc_osc_setup(struct device_node *np, void __iomem *sckcr)
>  {
>  	struct clk_hw *hw;
>  	u32 frequency = 0;
> @@ -356,8 +356,8 @@ at91_clk_register_sam9x5_slow(void __iomem *sckcr,
>  	return hw;
>  }
>  
> -void __init of_at91sam9x5_clk_slow_setup(struct device_node *np,
> -					 void __iomem *sckcr)
> +static void __init
> +of_at91sam9x5_clk_slow_setup(struct device_node *np, void __iomem *sckcr)
>  {
>  	struct clk_hw *hw;
>  	const char *parent_names[2];
> 
> -- 
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/5] clk: at91: move slow clock controller clocks to sckc.c Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-09-20 23:00 +0200
  Re: [PATCH v3 1/5] clk: at91: move slow clock controller clocks to  sckc.c Stephen Boyd <sboyd@codeaurora.org> - 2016-09-21 02:10 +0200
    Re: [PATCH v3 1/5] clk: at91: move slow clock controller clocks to  sckc.c Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-09-21 10:10 +0200

csiph-web