Re: [PATCH] ARM: tegra: nyan: Enable GPU node and related supply

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Jon Hunter <jonathanh@nvidia.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: tegra: nyan: Enable GPU node and related supply
Date	Wed, 21 Sep 2016 10:00:01 +0200
Message-ID	<sjKBH-6bG-9@gated-at.bofh.it> (permalink)
References	<siL6N-IX-35@gated-at.bofh.it> <sjsls-2V3-17@gated-at.bofh.it> <sjxO9-6z2-15@gated-at.bofh.it>
X-PGP-Universal	processed; by hqnvupgp08.nvidia.com on Wed, 21 Sep 2016 00:51:56 -0700
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
MIME-Version	1.0
X-Originating-IP	[10.21.132.118]
X-Clientproxiedby	DRUKMAIL102.nvidia.com (10.25.59.20) To UKMAIL101.nvidia.com (10.26.138.13)
Content-Type	text/plain; charset="utf-8"
Content-Transfer-Encoding	8BIT
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	59
Organization	linux.* mail to news gateway
X-Original-Cc	<linux-tegra@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>, Stephen Warren <swarren@wwwdotorg.org>
X-Original-Date	Wed, 21 Sep 2016 08:57:26 +0100
X-Original-Message-ID	<e95335ae-ad19-b8cd-634b-63c6a0b88e01@nvidia.com>
X-Original-References	<20160918141311.17140-1-contact@paulk.fr> <f2489bf5-bb08-11f5-1b53-7a1568f20b6b@nvidia.com> <1474395433.1215.23.camel@paulk.fr>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1487879

Show key headers only | View raw

On 20/09/16 19:17, Paul Kocialkowski wrote:
> * PGP Signed by an unknown key
> 
> Le mardi 20 septembre 2016 à 13:24 +0100, Jon Hunter a écrit :
>> On 18/09/16 15:13, Paul Kocialkowski wrote:
>>>
>>> This enables the GPU node for tegra124 nyan boards, which is required to
>>> get graphics acceleration with nouveau on these devices.
>>>
>>> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
>>> ---
>>>  arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +++++++-
>>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi
>>> b/arch/arm/boot/dts/tegra124-nyan.dtsi
>>> index dab9509..225ca77 100644
>>> --- a/arch/arm/boot/dts/tegra124-nyan.dtsi
>>> +++ b/arch/arm/boot/dts/tegra124-nyan.dtsi
>>> @@ -42,6 +42,12 @@
>>>  		};
>>>  	};
>>>  
>>> +	gpu@0,57000000 {
>>> +		status = "okay";
>>> +
>>> +		vdd-supply = <&vdd_gpu>;
>>> +	};
>>> +
>>>  	serial@70006000 {
>>>  		/* Debug connector on the bottom of the board near SD card.
>>> */
>>>  		status = "okay";
>>> @@ -214,7 +220,7 @@
>>>  					regulator-always-on;
>>>  				};
>>>  
>>> -				sd6 {
>>> +				vdd_gpu: sd6 {
>>>  					regulator-name = "+VDD_GPU_AP";
>>>  					regulator-min-microvolt = <650000>;
>>>  					regulator-max-microvolt =
>>> <1200000>;
>>>
>>
>> Looks good to me. I see the following error when booting but looking at the
>> code appears to be benign. Thierry, Alex, is this normal/okay?
> 
> I have the same messages and asked Alexandre about them the other day. He told
> me that it looks normal.

Ok great. Hopefully, Alex can ACK then.

Cheers
Jon

-- 
nvpublic

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: tegra: nyan: Enable GPU node and related supply Paul Kocialkowski <contact@paulk.fr> - 2016-09-18 16:20 +0200
  Re: [PATCH] ARM: tegra: nyan: Enable GPU node and related supply Jon Hunter <jonathanh@nvidia.com> - 2016-09-20 14:30 +0200
    Re: [PATCH] ARM: tegra: nyan: Enable GPU node and related supply Paul Kocialkowski <contact@paulk.fr> - 2016-09-20 20:20 +0200
      Re: [PATCH] ARM: tegra: nyan: Enable GPU node and related supply Jon Hunter <jonathanh@nvidia.com> - 2016-09-21 10:00 +0200

csiph-web