Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1487762

Re: [PATCH] ALSA: snd-usb-line6 depends on CONFIG_SND_HWDEP

From Takashi Sakamoto <o-takashi@sakamocchi.jp>
Newsgroups linux.kernel
Subject Re: [PATCH] ALSA: snd-usb-line6 depends on CONFIG_SND_HWDEP
Date 2016-09-21 04:00 +0200
Message-ID <sjEZk-2uI-3@gated-at.bofh.it> (permalink)
References <sjByp-xU-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Sep 21 2016 07:14, Valdis Kletnieks wrote:
> ALSA - snd-usb-line6 depends on CONFIG_SND_HWDEP
>
> ERROR: "snd_hwdep_new" [sound/usb/line6/snd-usb-line6.ko] undefined!
> scripts/Makefile.modpost:91: recipe for target '__modpost' failed
> make[1]: *** [__modpost] Error 1
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>

Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

As a nitpicking, I think it better to change the subject line with a 
prefix of 'ALSA: line6:' or 'ALSA: usb-line6:', following to our fashion.

> diff --git a/sound/usb/line6/Kconfig b/sound/usb/line6/Kconfig
> index 8ffcf48097d9..39b400392d71 100644
> --- a/sound/usb/line6/Kconfig
> +++ b/sound/usb/line6/Kconfig
> @@ -2,6 +2,7 @@ config SND_USB_LINE6
>  	tristate
>  	select SND_RAWMIDI
>  	select SND_PCM
> +	select SND_HWDEP
>
>  config SND_USB_POD
>  	tristate "Line 6 POD USB support"


Thanks

Takashi Sakamoto

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ALSA: snd-usb-line6 depends on CONFIG_SND_HWDEP Valdis Kletnieks <Valdis.Kletnieks@vt.edu> - 2016-09-21 00:20 +0200
  Re: [PATCH] ALSA: snd-usb-line6 depends on CONFIG_SND_HWDEP Takashi Sakamoto <o-takashi@sakamocchi.jp> - 2016-09-21 04:00 +0200
    Re: [PATCH] ALSA: snd-usb-line6 depends on CONFIG_SND_HWDEP Takashi Iwai <tiwai@suse.de> - 2016-09-21 14:40 +0200
      Re: [PATCH] ALSA: snd-usb-line6 depends on CONFIG_SND_HWDEP Takashi Sakamoto <o-takashi@sakamocchi.jp> - 2016-09-21 15:30 +0200
        Re: [PATCH] ALSA: snd-usb-line6 depends on CONFIG_SND_HWDEP Takashi Iwai <tiwai@suse.de> - 2016-09-21 15:40 +0200
          Re: [PATCH] ALSA: snd-usb-line6 depends on CONFIG_SND_HWDEP Takashi Sakamoto <o-takashi@sakamocchi.jp> - 2016-09-22 01:10 +0200

csiph-web