Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1486636

Re: [PATCH 1/8] samples: move accounting example code from Documentation

Show all headers | View raw

On Mon, 19 Sep 2016 08:47:32 -0600
Shuah Khan <shuahkh@osg.samsung.com> wrote:

> Move accounting examples to samples and remove it from Documentation
> Makefile. Create a new Makefile to build accounting. It can be built
> from top level directory or from accounting directory:

So I like the basic idea of these patches; it's the direction we've been
trying to push things for a little bit.  I have a couple of specific
comments for this one that may well apply to the others as well.

1) Is samples the right destination for these utilities?  Some of them
   might well be better placed under tools/ instead.  I'm not sure we've
   ever formally stated the purpose of those two subtrees; I see samples/
   as demonstrations of how to use something, while tools/ are utilities
   you might actually want to use for some purpose.  Something like
   getdelays might well fall into the latter group.  But maybe others
   disagree?

2) Tools like getdelays are referenced in the documents that have been
   left behind; see accounting/delay-accounting.txt, for example.  Those
   documents should be updated so that readers know where to find the
   referenced programs, wherever they end up.  Converting them to Sphinx
   while you're at it is an extra-credit exercise :)

Thanks,

jon

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] Move runnable examples code from Documentation to samples Shuah Khan <shuahkh@osg.samsung.com> - 2016-09-19 16:50 +0200
  [PATCH 3/8] samples: move laptops example code from Documentation Shuah Khan <shuahkh@osg.samsung.com> - 2016-09-19 16:50 +0200
    Re: [PATCH 3/8] samples: move laptops example code from  Documentation Jonathan Corbet <corbet@lwn.net> - 2016-09-19 18:20 +0200
      Re: [PATCH 3/8] samples: move laptops example code from Documentation Shuah Khan <shuahkh@osg.samsung.com> - 2016-09-20 18:20 +0200
  [PATCH 2/8] samples: move auxdisplay example code from Documentation Shuah Khan <shuahkh@osg.samsung.com> - 2016-09-19 16:50 +0200
    Re: [PATCH 2/8] samples: move auxdisplay example code from  Documentation Jonathan Corbet <corbet@lwn.net> - 2016-09-19 18:10 +0200
      Re: samples: move auxdisplay example code from Documentation SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-19 22:00 +0200
      Re: [PATCH 2/8] samples: move auxdisplay example code from  Documentation Shuah Khan <shuahkh@osg.samsung.com> - 2016-09-20 18:20 +0200
  [PATCH 8/8] samples: move watchdog example code from Documentation Shuah Khan <shuahkh@osg.samsung.com> - 2016-09-19 16:50 +0200
    Re: [PATCH 8/8] samples: move watchdog example code from  Documentation Jonathan Corbet <corbet@lwn.net> - 2016-09-19 18:30 +0200
  [PATCH 5/8] samples: move misc-devices/mei example code from Documentation Shuah Khan <shuahkh@osg.samsung.com> - 2016-09-19 16:50 +0200
    Re: [PATCH 5/8] samples: move misc-devices/mei example code from  Documentation Jonathan Corbet <corbet@lwn.net> - 2016-09-19 18:20 +0200
      RE: [PATCH 5/8] samples: move misc-devices/mei example code from  Documentation "Winkler, Tomas" <tomas.winkler@intel.com> - 2016-09-20 08:20 +0200
        Re: [PATCH 5/8] samples: move misc-devices/mei example code from  Documentation Shuah Khan <shuahkh@osg.samsung.com> - 2016-09-20 19:30 +0200
  [PATCH 1/8] samples: move accounting example code from Documentation Shuah Khan <shuahkh@osg.samsung.com> - 2016-09-19 17:00 +0200
    Re: [PATCH 1/8] samples: move accounting example code from  Documentation Jonathan Corbet <corbet@lwn.net> - 2016-09-19 18:10 +0200
      Re: [PATCH 1/8] samples: move accounting example code from  Documentation Shuah Khan <shuahkh@osg.samsung.com> - 2016-09-20 18:10 +0200
  Re: [PATCH 0/8] Move runnable examples code from Documentation to samples Jani Nikula <jani.nikula@linux.intel.com> - 2016-09-19 17:50 +0200
  Re: [PATCH 4/8] samples: move mic/mpssd example code from  Documentation Jonathan Corbet <corbet@lwn.net> - 2016-09-19 18:20 +0200

csiph-web