Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1486657
| From | Kevin Hilman <khilman@baylibre.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] phy: meson-usb2: Fix build dependency |
| Date | 2016-09-19 18:50 +0200 |
| Message-ID | <sj9Vv-7RM-3@gated-at.bofh.it> (permalink) |
| References | <shQLf-6I2-5@gated-at.bofh.it> <siS8h-51K-1@gated-at.bofh.it> |
| Organization | BayLibre |
Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes: > Hi Axel, > > On Fri, Sep 16, 2016 at 4:07 AM, Axel Lin <axel.lin@ingics.com> wrote: >> of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below >> build error: >> >> drivers/built-in.o: In function `phy_meson_usb2_probe': >> debugfs.c:(.text+0x76b4): undefined reference to `of_usb_get_dr_mode_by_phy' >> Makefile:961: recipe for target 'vmlinux' failed >> make: *** [vmlinux] Error 1 >> >> Signed-off-by: Axel Lin <axel.lin@ingics.com> >> --- >> drivers/phy/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig >> index 6ad87ec..cc27c12 100644 >> --- a/drivers/phy/Kconfig >> +++ b/drivers/phy/Kconfig >> @@ -458,6 +458,8 @@ config PHY_MESON_USB2 >> tristate "Meson USB2 PHY driver" >> default ARCH_MESON >> depends on OF && (ARCH_MESON || COMPILE_TEST) >> + depends on USB_SUPPORT >> + select USB_COMMON >> select GENERIC_PHY >> help >> Enable this to support the Meson USB2 PHYs found in Meson8b >> -- >> 2.7.4 >> > thanks for this patch! > > How do we handle patches for drivers which will (unfortunately) not > land in the linux 4.8 - should I integrate that into v3 of the patch > (which I'll have to send anyways) or do we keep them separate? > Maybe Kishon and/or Kevin can share their opinion on this. It's up to Kishon if he wants a v3, or if he can fold in the fix himself. Kevin
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] phy: meson-usb2: Fix build dependency Axel Lin <axel.lin@ingics.com> - 2016-09-16 04:10 +0200
Re: [PATCH] phy: meson-usb2: Fix build dependency Martin Blumenstingl <martin.blumenstingl@googlemail.com> - 2016-09-18 23:50 +0200
Re: [PATCH] phy: meson-usb2: Fix build dependency Kevin Hilman <khilman@baylibre.com> - 2016-09-19 18:50 +0200
Re: [PATCH] phy: meson-usb2: Fix build dependency Kishon Vijay Abraham I <kishon@ti.com> - 2016-09-21 06:10 +0200
Re: [PATCH] phy: meson-usb2: Fix build dependency Axel Lin <axel.lin@ingics.com> - 2016-09-21 06:20 +0200
Re: [PATCH] phy: meson-usb2: Fix build dependency Kevin Hilman <khilman@baylibre.com> - 2016-09-21 07:20 +0200
csiph-web