Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1486628

[PATCH 4/5] GPU-DRM: Replace a kzalloc() call by kcalloc() in drm_legacy_addbufs_sg()

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 19 Sep 2016 17:30:31 +0200

The script "checkpatch.pl" can point information out like the following.

WARNING: Prefer kcalloc over kzalloc with multiply

Thus fix the affected source code place.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/gpu/drm/drm_bufs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_bufs.c b/drivers/gpu/drm/drm_bufs.c
index 36dd685..adb1dd7 100644
--- a/drivers/gpu/drm/drm_bufs.c
+++ b/drivers/gpu/drm/drm_bufs.c
@@ -1117,8 +1117,7 @@ static int drm_legacy_addbufs_sg(struct drm_device *dev,
 		return -EINVAL;
 	}
 
-	entry->buflist = kzalloc(count * sizeof(*entry->buflist),
-				GFP_KERNEL);
+	entry->buflist = kcalloc(count, sizeof(*entry->buflist), GFP_KERNEL);
 	if (!entry->buflist) {
 		mutex_unlock(&dev->struct_mutex);
 		atomic_dec(&dev->buf_alloc);
-- 
2.10.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] GPU-DRM: Fine-tuning for four function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-19 18:00 +0200
  [PATCH 4/5] GPU-DRM: Replace a kzalloc() call by kcalloc() in  drm_legacy_addbufs_sg() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-19 18:00 +0200
    Re: [PATCH 4/5] GPU-DRM: Replace a kzalloc() call by kcalloc() in  drm_legacy_addbufs_sg() Daniel Vetter <daniel@ffwll.ch> - 2016-09-21 13:30 +0200
  [PATCH 3/5] GPU-DRM: Replace a kzalloc() call by kcalloc() in  drm_legacy_addbufs_agp() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-19 18:00 +0200
  [PATCH 1/5] GPU-DRM: Use kmalloc_array() in drm_legacy_addbufs_pci() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-19 18:00 +0200
  [PATCH 2/5] GPU-DRM: Replace two kzalloc() calls by kcalloc() in  drm_legacy_addbufs_pci() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-19 18:00 +0200

csiph-web