Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1486316

Re: [PATCH] kvm: svm: fix unsigned compare less than zero comparison

Show all headers | View raw

On Mon, Sep 19, 2016 at 07:11:59AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> vm_data->avic_vm_id is a u32, so the check for a error
> return (less than zero) such as -EAGAIN from
> avic_get_next_vm_id currently has no effect whatsoever.
> Fix this by using a temporary int for the comparison
> and assign vm_data->avic_vm_id to this. I used an explicit
> u32 cast in the assignment to show why vm_data->avic_vm_id
> cannot be used in the assign/compare steps.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Joerg Roedel <jroedel@suse.de>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] kvm: svm: fix unsigned compare less than zero comparison Colin King <colin.king@canonical.com> - 2016-09-19 08:20 +0200
  Re: [PATCH] kvm: svm: fix unsigned compare less than zero comparison Joerg Roedel <joro@8bytes.org> - 2016-09-19 12:10 +0200
  Re: [PATCH] kvm: svm: fix unsigned compare less than zero comparison Paolo Bonzini <pbonzini@redhat.com> - 2016-09-19 13:30 +0200

csiph-web