Re: [PATCH] mtd: Allocate bdi objects dynamically

Path	csiph.com!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod
From	Richard Weinberger <richard.weinberger@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mtd: Allocate bdi objects dynamically
Date	Sat, 17 Sep 2016 16:50:01 +0200
Message-ID	<sip6h-3Li-3@gated-at.bofh.it> (permalink)
References	<s2rvs-1NC-11@gated-at.bofh.it> <s2rvs-1NC-5@gated-at.bofh.it>
X-Original-To	Sandeep Jain <Sandeep_Jain@mentor.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=SMOMPNhKawU3QBs6g5PVDdOLlfymDbGVmZ95MhuyOLc=; b=xWydRTceufS+9eiLBNBKnQq7zpi4icMvDggRrAiybDA7XVPzdWbkSDnClGC/GOcniX qWgXE66jbY+vHvuALh4elzfwBLLHkn9bE1IhAwS9M5t1lKSnsv0cibcUYGuyIRfrw5bd rK1GJ6IQZo5FxJTB/UZ8GtFBPlpAHaEALzU+jwmAQyd+bFkkYtsyWQsLrJsPb4LsM7mi mOml1E6y1UdJmuBm8OeSjM3rqegS0iFT11T7R7UxmLqkz8gxeKgVv5DJlq1qoF5oCpav Cd4vipTlBeS4BAnAhzXVWFk+ehhBd5rpYgaeUgb/2h2qFsNSlr7V+V/kDkTz/jJpQ1JP py+g==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=SMOMPNhKawU3QBs6g5PVDdOLlfymDbGVmZ95MhuyOLc=; b=GpNPPQ/hliBmBL+l2Bn0RsLWvLaJpVCcVnmOwbqBSP8imSOqtr2PCUEi9pvZVkitpD uTPeq+fiOBOZ05+prKRqk2JwAvyA+FhCRKhuEJbKgTLLoBFt39tQp3GZ8sHKvOYxepgE osEcZpzcyaC2nI1WpZ9qBrPv8Z1Vf8NnCBv7/08a93mSc4C5egg2C8Cmh89mtmmmF5uE pJ72jmzzwlZRM1/u4wGsSQtrOOS2o/r+tzw8/sJT/6H0MfukRBuR8jMgloKoFvsI/74o jfatuwqpTXaQiRXk+xr48Vn9gBnTwF3g8+H4mC0L47vIX75WxhNF2q9GrpKI3u2Ks2vE nuZA==
X-Gm-Message-State	AE9vXwPDsWD45LTHdgF6EflISebrsdUoQlCaQdaTFZd/TYIlr+njeDRlGdACuJlXEudUwtSBY9S8mTSQRC72tQ==
X-Received	by 10.202.245.19 with SMTP id t19mr18759663oih.131.1474123308153; Sat, 17 Sep 2016 07:41:48 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	25
Organization	linux.* mail to news gateway
X-Original-Cc	David Woodhouse <dwmw2@infradead.org>, Brian Norris <computersforpeace@gmail.com>, "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>, LKML <linux-kernel@vger.kernel.org>, Steve Longerbeam <steve_longerbeam@mentor.com>, Jim Baxter <jim_baxter@mentor.com>
X-Original-Date	Sat, 17 Sep 2016 16:41:47 +0200
X-Original-Message-ID	<CAFLxGvx6B02c+HgYwJ8exVLT6owrkQL1Rq+X6VzUDKVUxE=aoQ@mail.gmail.com>
X-Original-References	<Sandeep_Jain@mentor.com> <1470319275-9465-1-git-send-email-Sandeep_Jain@mentor.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1485539

Show key headers only | View raw

On Thu, Aug 4, 2016 at 4:01 PM, Sandeep Jain <Sandeep_Jain@mentor.com> wrote:
> From: Steve Longerbeam <steve_longerbeam@mentor.com>
>
> The MTD backing dev info objects mtd_bdi was statically allocated.
> So when MTD is built as a loadable module, this object fall in the
> vmalloc address space.
>
> The problem with that, is that the BDI APIs use wake_up_bit(), which calls
> virt_to_page() to retrieve the memory zone of the page containing the
> wait_queue to wake up, and virt_to_page() is not valid for vmalloc or
> highmem addresses.
>
> Fix this by allocating the BDI objects dynamically with kmalloc. The
> objects now fall in the logical address space so that BDI APIs will
> work in all cases (mtd builtin or module).
>
> Signed-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>
> Signed-off-by: Jim Baxter <jim_baxter@mentor.com>
> Signed-off-by: Sandeep Jain <Sandeep_Jain@mentor.com>

Reviewed-by: Richard Weinberger <richard@nod.at>

-- 
Thanks,
//richard

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] mtd: Allocate bdi objects dynamically Richard Weinberger <richard.weinberger@gmail.com> - 2016-09-17 16:50 +0200

csiph-web