Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1485537

Re: [PATCH v2 1/4] clk: sunxi-ng: Add A64 clocks

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Stephen,

On Wed, Sep 14, 2016 at 02:45:54PM -0700, Stephen Boyd wrote:
> On 09/09, Maxime Ripard wrote:
> > index 106cba27c331..964f22091a10 100644
> > --- a/drivers/clk/sunxi-ng/Makefile
> > +++ b/drivers/clk/sunxi-ng/Makefile
> > @@ -22,3 +22,4 @@ obj-$(CONFIG_SUN6I_A31_CCU)	+= ccu-sun6i-a31.o
> >  obj-$(CONFIG_SUN8I_A23_CCU)	+= ccu-sun8i-a23.o
> >  obj-$(CONFIG_SUN8I_A33_CCU)	+= ccu-sun8i-a33.o
> >  obj-$(CONFIG_SUN8I_H3_CCU)	+= ccu-sun8i-h3.o
> > +obj-$(CONFIG_SUN50I_A64_CCU)	+= ccu-sun50i-a64.o
> 
> Maybe do alphanumeric ordering?

Yes, of course.

> > diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-a64.c b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c
> > new file mode 100644
> > index 000000000000..d51ee416f515
> > --- /dev/null
> > +++ b/drivers/clk/sunxi-ng/ccu-sun50i-a64.c
> > @@ -0,0 +1,870 @@
> > +
> > +static void __init sun50i_a64_ccu_setup(struct device_node *node)
> > +{
> > +	void __iomem *reg;
> > +	u32 val;
> > +
> > +	reg = of_io_request_and_map(node, 0, of_node_full_name(node));
> > +	if (IS_ERR(reg)) {
> > +		pr_err("%s: Could not map the clock registers\n",
> > +		       of_node_full_name(node));
> > +		return;
> > +	}
> > +
> > +	/* Force the PLL-Audio-1x divider to 4 */
> > +	val = readl(reg + SUN50I_A64_PLL_AUDIO_REG);
> > +	val &= ~GENMASK(19, 16);
> > +	writel(val | (3 << 16), reg + SUN50I_A64_PLL_AUDIO_REG);
> > +
> > +	writel(0x515, reg + SUN50I_A64_PLL_MIPI_REG);
> > +
> > +	sunxi_ccu_probe(node, reg, &sun50i_a64_ccu_desc);
> > +}
> > +CLK_OF_DECLARE(sun50i_a64_ccu, "allwinner,sun50i-a64-ccu",
> > +	       sun50i_a64_ccu_setup);
> 
> Is there a reason it can't be a platform driver?

We have timers connected to those clocks. I'm not sure we'll ever use
them, since we also have the arch timers, and we can always change
that later, I'll change that.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/4] arm64: Allwinner A64 support based on sunxi-ng Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-09 22:20 +0200
  [PATCH v2 2/4] Documentation: devicetree: add vendor prefix for Pine64 Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-09 22:20 +0200
    Re: [PATCH v2 2/4] Documentation: devicetree: add vendor prefix for Pine64 Chen-Yu Tsai <wens@csie.org> - 2016-09-10 04:00 +0200
  [PATCH v2 3/4] arm64: dts: add Allwinner A64 SoC .dtsi Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-09 22:20 +0200
    Re: [PATCH v2 3/4] arm64: dts: add Allwinner A64 SoC .dtsi Chen-Yu Tsai <wens@csie.org> - 2016-09-10 04:30 +0200
    Re: [PATCH v2 3/4] arm64: dts: add Allwinner A64 SoC .dtsi André Przywara <andre.przywara@arm.com> - 2016-09-15 02:20 +0200
      Re: [PATCH v2 3/4] arm64: dts: add Allwinner A64 SoC .dtsi Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-17 17:00 +0200
  [PATCH v2 4/4] arm64: dts: add Pine64 support Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-09 22:20 +0200
    Re: [PATCH v2 4/4] arm64: dts: add Pine64 support Chen-Yu Tsai <wens@csie.org> - 2016-09-10 04:40 +0200
      Re: [PATCH v2 4/4] arm64: dts: add Pine64 support Andre Przywara <andre.przywara@arm.com> - 2016-09-12 12:20 +0200
        Re: [PATCH v2 4/4] arm64: dts: add Pine64 support Chen-Yu Tsai <wens@csie.org> - 2016-09-19 17:20 +0200
  Re: [PATCH v2 1/4] clk: sunxi-ng: Add A64 clocks Stephen Boyd <sboyd@codeaurora.org> - 2016-09-14 23:50 +0200
    Re: [PATCH v2 1/4] clk: sunxi-ng: Add A64 clocks Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-17 16:30 +0200
  Re: [PATCH v2 1/4] clk: sunxi-ng: Add A64 clocks Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-17 16:10 +0200

csiph-web