Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1485888

Re: [PATCH] sysfs print name of undiscoverable attribute group as well

From Johannes Thumshirn <jthumshirn@suse.de>
Newsgroups linux.kernel
Subject Re: [PATCH] sysfs print name of undiscoverable attribute group as well
Date 2016-09-18 20:00 +0200
Message-ID <siOxI-2Fp-5@gated-at.bofh.it> (permalink)
References <shKPv-2Mg-17@gated-at.bofh.it> <siERH-5bE-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sun, Sep 18, 2016 at 09:36:02AM +0200, Greg KH wrote:
> On Thu, Sep 15, 2016 at 09:44:06PM +0200, Johannes Thumshirn wrote:
> > Print the name of an undiscoverable attribute group as well, not just
> > the pointer's address.
> 
> Shouldn't we just drop the pointer address and use the name?  It's bad
> form to be printing kernel addresses to the syslog these days given that
> it is a security information leak :(

Probably yes. Given it's not etremely helpful when debugging either
I'll send a v2 with the address dropped.

Thanks,
	Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] sysfs print name of undiscoverable attribute group as well Johannes Thumshirn <jthumshirn@suse.de> - 2016-09-15 21:50 +0200
  Re: [PATCH] sysfs print name of undiscoverable attribute group as  well Greg KH <gregkh@linuxfoundation.org> - 2016-09-18 09:40 +0200
    Re: [PATCH] sysfs print name of undiscoverable attribute group as  well Johannes Thumshirn <jthumshirn@suse.de> - 2016-09-18 20:00 +0200
    Re: [PATCH] sysfs print name of undiscoverable attribute group as  well Johannes Thumshirn <jthumshirn@suse.de> - 2016-09-19 10:10 +0200

csiph-web