Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1485895

Re: [GIT pull] irq fixes for 4.8

Show all headers | View raw

On Sun, Sep 18, 2016 at 1:05 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
>
> Boris Brezillon (2):
>       genirq: Provide irq_gc_{lock_irqsave,unlock_irqrestore}() helpers

This seems somewhat questionable.

The non-irqsafe versions of these functions have specialized non-SMP
versions for them. The new ones don't.

I pulled it, because I think it's actually the old versions that are
garbage (the locking should become a no-op on UP regardless - except
for the preemption issue which I don't see why it wouldn't be real),
but I think this is inconsistent and should be fixed (or a comment
added about why it is ok).

              Linus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT pull] irq fixes for 4.8 Thomas Gleixner <tglx@linutronix.de> - 2016-09-18 10:10 +0200
  Re: [GIT pull] irq fixes for 4.8 Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-18 20:20 +0200
    Re: [GIT pull] irq fixes for 4.8 Thomas Gleixner <tglx@linutronix.de> - 2016-09-19 09:20 +0200

csiph-web