Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1485829

Re: [PATCH] perf, tools: Handle events including .c and .o

Show all headers | View raw

On Sun, Sep 18, 2016 at 11:03:27AM +0200, Jiri Olsa wrote:
> On Sat, Sep 17, 2016 at 06:02:46PM -0700, Andi Kleen wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> > 
> > This is a generic bug fix, but it helps with Sukadev's JSON event tree
> > where such events can happen.
> > 
> > Any event inclduing a .c/.o/.bpf currently triggers BPF compilation or loading
> > and then an error.  This can happen for some Intel JSON events, which cannot
> > be used.
> > 
> > Fix the scanner to only match for .o or .c or .bpf at the end.
> > This will prevent loading multiple BPF scripts separated with comma,
> > but I assume this is acceptable.
> > 
> > Cc: wangnan0@huawei.com
> > Cc: sukadev@linux.vnet.ibm.com
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
> > ---
> >  tools/perf/util/parse-events.l | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
> > index 7a2519435da0..64ca26e4ed2d 100644
> > --- a/tools/perf/util/parse-events.l
> > +++ b/tools/perf/util/parse-events.l
> > @@ -162,8 +162,8 @@ modifier_bp	[rwx]{1,3}
> >  		}
> >  
> >  {event_pmu}	|
> > -{bpf_object}	|
> > -{bpf_source}	|
> > +({bpf_object}$)	|
> > +({bpf_source}$)	|
> 
> why are the () braces necessary? anyway:

Flex complains otherwise, I think because it's used with OR (|)

-Andi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] perf, tools: Handle events including .c and .o Andi Kleen <andi@firstfloor.org> - 2016-09-18 03:10 +0200
  Re: [PATCH] perf, tools: Handle events including .c and .o Jiri Olsa <jolsa@redhat.com> - 2016-09-18 11:10 +0200
    Re: [PATCH] perf, tools: Handle events including .c and .o Andi Kleen <ak@linux.intel.com> - 2016-09-18 17:00 +0200
  Re: [PATCH] perf, tools: Handle events including .c and .o "Wangnan (F)" <wangnan0@huawei.com> - 2016-09-18 12:30 +0200
    Re: [PATCH] perf, tools: Handle events including .c and .o Andi Kleen <ak@linux.intel.com> - 2016-09-18 17:00 +0200
      Re: [PATCH] perf, tools: Handle events including .c and .o "Wangnan (F)" <wangnan0@huawei.com> - 2016-09-19 05:00 +0200

csiph-web