Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1485812

[PATCH] drm/amdgpu: remove unused functions

Path csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.szaf.org!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Baoyou Xie <baoyou.xie@linaro.org>
Newsgroups linux.kernel
Subject [PATCH] drm/amdgpu: remove unused functions
Date Sun, 18 Sep 2016 16:20:01 +0200
Message-ID <siL6N-IX-3@gated-at.bofh.it> (permalink)
X-Original-To oded.gabbay@gmail.com, alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie, samuel.li@amd.com, Jammy.Zhou@amd.com
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=a1GarpQfWrPxL68TO2MOwbH6gc1+zSW0RZBT4JEgcEY=; b=Bt/96OexaW1WFnwzVm3t4OLMNWe2zK/2J/8nRdc0LKs/n1c0Y+xyES6duc1tJ/GgEm fdy22Ws2aE5LPzppBrlsQpavEM8UOieZbwdbC300hdGnWGj6flNCRlrDHIRln95c5iTS MjVy02DHfhXAo2Q6loVbER/WVwKO3GYtnJcnE=
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=a1GarpQfWrPxL68TO2MOwbH6gc1+zSW0RZBT4JEgcEY=; b=PpHImo7wO8v2pI2auJNnpYc7+tdGC79+8r4WIse0FHMI4b46bnO1MfVS0SfF0p9X/Q fYpGf3ulmt7PXNpjPOI9ynpyGtpN/jXgz0XAyF+e5dXv17bCr7ANlN8VudesAiKFg5ap OhdfOZQ+EOQvdOnuPKRf5Zlz+DZYsI1VaYtjZKVY9arZ2uIW57pOosO3N1HuhNkTjSRJ Qq8VjtewIHohpRexPycieMczk6Nb88TB8Nun7csVZGA6j7tcofbWuOyWWu2THVy+1qMj psltFFXSxQZnhbqp37Sj34pMPQmUwYiv6YQW5NwPGkfhuzMpmdTGWj/82J3f1UGbAh2N wLjw==
X-Gm-Message-State AE9vXwM7gLWz561Z85my7XWJug4h1frAaaEFOWULfvwDcL/lyOcGNufw90J+eJZW94MHcG55
X-Received by 10.98.216.6 with SMTP id e6mr39076823pfg.106.1474208023432; Sun, 18 Sep 2016 07:13:43 -0700 (PDT)
X-Mailer git-send-email 2.7.4
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 52
Organization linux.* mail to news gateway
X-Original-Cc dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, baoyou.xie@linaro.org, xie.baoyou@zte.comm.cn
X-Original-Date Sun, 18 Sep 2016 22:13:19 +0800
X-Original-Message-ID <1474207999-3380-1-git-send-email-baoyou.xie@linaro.org>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1485812

Show key headers only | View raw


We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c:146:5: warning: no previous prototype for 'pool_to_domain' [-Wmissing-prototypes]
drivers/gpu/drm/amd/amdgpu/cz_smc.c:104:5: warning: no previous prototype for 'cz_send_msg_to_smc_with_parameter_async' [-Wmissing-prototypes]

In fact, both functions are called by no one and not exported,
so this patch removes them.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 8 --------
 drivers/gpu/drm/amd/amdgpu/cz_smc.c        | 7 -------
 2 files changed, 15 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
index d080d08..dba8a5b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
@@ -143,14 +143,6 @@ int amdgpu_amdkfd_resume(struct amdgpu_device *rdev)
 	return r;
 }
 
-u32 pool_to_domain(enum kgd_memory_pool p)
-{
-	switch (p) {
-	case KGD_POOL_FRAMEBUFFER: return AMDGPU_GEM_DOMAIN_VRAM;
-	default: return AMDGPU_GEM_DOMAIN_GTT;
-	}
-}
-
 int alloc_gtt_mem(struct kgd_dev *kgd, size_t size,
 			void **mem_obj, uint64_t *gpu_addr,
 			void **cpu_ptr)
diff --git a/drivers/gpu/drm/amd/amdgpu/cz_smc.c b/drivers/gpu/drm/amd/amdgpu/cz_smc.c
index 69ac373c4..db67e0c 100644
--- a/drivers/gpu/drm/amd/amdgpu/cz_smc.c
+++ b/drivers/gpu/drm/amd/amdgpu/cz_smc.c
@@ -101,13 +101,6 @@ int cz_send_msg_to_smc(struct amdgpu_device *adev, u16 msg)
 	return 0;
 }
 
-int cz_send_msg_to_smc_with_parameter_async(struct amdgpu_device *adev,
-						u16 msg, u32 parameter)
-{
-	WREG32(mmSMU_MP1_SRBM2P_ARG_0, parameter);
-	return cz_send_msg_to_smc_async(adev, msg);
-}
-
 int cz_send_msg_to_smc_with_parameter(struct amdgpu_device *adev,
 						u16 msg, u32 parameter)
 {
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH] drm/amdgpu: remove unused functions Baoyou Xie <baoyou.xie@linaro.org> - 2016-09-18 16:20 +0200
  Re: [PATCH] drm/amdgpu: remove unused functions Alex Deucher <alexdeucher@gmail.com> - 2016-09-20 06:30 +0200

csiph-web