Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1485800
| From | Frederic Weisbecker <fweisbec@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/5] u64_stats: Introduce IRQs disabled helpers |
| Date | 2016-09-18 15:40 +0200 |
| Message-ID | <siKu5-f7-17@gated-at.bofh.it> (permalink) |
| References | <scXkm-s8-19@gated-at.bofh.it> <scXkm-s8-31@gated-at.bofh.it> <scXNo-El-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Sep 02, 2016 at 04:35:54PM +0200, Paolo Bonzini wrote:
>
>
> On 02/09/2016 16:03, Frederic Weisbecker wrote:
> > static inline unsigned int u64_stats_fetch_begin(const struct u64_stats_sync *syncp)
> > {
> > -#if BITS_PER_LONG==32 && defined(CONFIG_SMP)
> > - return read_seqcount_begin(&syncp->seq);
> > -#else
> > -#if BITS_PER_LONG==32
> > +#if BITS_PER_LONG==32 && !defined(CONFIG_SMP)
> > preempt_disable();
> > +#else
>
> This should be #endif, or this side ends without a "return" statement.
Good catch!
Thanks Paolo!
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH 3/5] u64_stats: Introduce IRQs disabled helpers Frederic Weisbecker <fweisbec@gmail.com> - 2016-09-18 15:40 +0200
csiph-web