Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1485264
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/4] serial: 8250: of: Load TX FIFO Load Size from DT |
| Date | 2016-09-16 21:30 +0200 |
| Message-ID | <si6ZH-ym-3@gated-at.bofh.it> (permalink) |
| References | <si6ZH-ym-5@gated-at.bofh.it> <si6ZH-ym-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Sep 08, 2016 at 11:12:19AM -0500, tthayer@opensource.altera.com wrote:
> From: Thor Thayer <tthayer@opensource.altera.com>
>
> Initialize the tx_loadsz parameter if it is defined in the
> device tree.
>
> Signed-off-by: Thor Thayer <tthayer@opensource.altera.com>
> ---
> drivers/tty/serial/8250/8250_of.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/tty/serial/8250/8250_of.c b/drivers/tty/serial/8250/8250_of.c
> index 38963d7..3e4be2f 100644
> --- a/drivers/tty/serial/8250/8250_of.c
> +++ b/drivers/tty/serial/8250/8250_of.c
> @@ -195,6 +195,7 @@ static int of_platform_serial_probe(struct platform_device *ofdev)
> switch (port_type) {
> case PORT_8250 ... PORT_MAX_8250:
> {
> + u32 prop;
> struct uart_8250_port port8250;
> memset(&port8250, 0, sizeof(port8250));
> port8250.port = port;
> @@ -202,6 +203,11 @@ static int of_platform_serial_probe(struct platform_device *ofdev)
> if (port.fifosize)
> port8250.capabilities = UART_CAP_FIFO;
>
> + /* Check for TX fifo load size */
> + if (of_property_read_u32(ofdev->dev.of_node,
> + "tx-loadsz", &prop) == 0)
> + port8250.tx_loadsz = prop;
This can be simplified to:
of_property_read_u32(ofdev->dev.of_node, "tx-loadsz", &port8250.tx_loadsz);
> +
> if (of_property_read_bool(ofdev->dev.of_node,
> "auto-flow-control"))
> port8250.capabilities |= UART_CAP_AFE;
> --
> 1.7.9.5
>
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH 2/4] serial: 8250: of: Load TX FIFO Load Size from DT Rob Herring <robh@kernel.org> - 2016-09-16 21:30 +0200 Re: [PATCH 2/4] serial: 8250: of: Load TX FIFO Load Size from DT Arnd Bergmann <arnd@arndb.de> - 2016-09-16 23:00 +0200
csiph-web