Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1485218

Re: [PATCH] IB/rxe: fix GFP_KERNEL in spinlock context

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 9/4/2016 6:01 AM, Moni Shoua wrote:
> On Fri, Sep 2, 2016 at 11:46 PM, Alexey Khoroshilov
> <khoroshilov@ispras.ru> wrote:
>> There is skb_clone(skb, GFP_KERNEL) in spinlock context
>> in rxe_rcv_mcast_pkt().
>>
>> Found by Linux Driver Verification project (linuxtesting.org).
>>
>> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
>> ---
>>  drivers/infiniband/sw/rxe/rxe_recv.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/infiniband/sw/rxe/rxe_recv.c b/drivers/infiniband/sw/rxe/rxe_recv.c
>> index 3d464c23e08b..144d2f129fcd 100644
>> --- a/drivers/infiniband/sw/rxe/rxe_recv.c
>> +++ b/drivers/infiniband/sw/rxe/rxe_recv.c
>> @@ -312,7 +312,7 @@ static void rxe_rcv_mcast_pkt(struct rxe_dev *rxe, struct sk_buff *skb)
>>                  * make a copy of the skb to post to the next qp
>>                  */
>>                 skb_copy = (mce->qp_list.next != &mcg->qp_list) ?
>> -                               skb_clone(skb, GFP_KERNEL) : NULL;
>> +                               skb_clone(skb, GFP_ATOMIC) : NULL;
>>
>>                 pkt->qp = qp;
>>                 rxe_add_ref(qp);
>> --
>> 2.7.4
>>
> Acked-by: Moni Shoua <monis@mellanox.com>
> 

Thanks, applied.

-- 
Doug Ledford <dledford@redhat.com>
    GPG Key ID: 0E572FDD

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] IB/rxe: fix GFP_KERNEL in spinlock context Doug Ledford <dledford@redhat.com> - 2016-09-16 20:00 +0200

csiph-web