Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1485120

Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible

Show all headers | View raw

On Thu, Sep 08, 2016 at 02:50:37PM +0200, Andreas Färber wrote:
> Am 08.09.2016 um 14:04 schrieb Andreas Färber:
> > Am 08.09.2016 um 09:53 schrieb Neil Armstrong:
> >> This patchset adds a specific compatible string in the Meson SPIFC driver for
> >> the Amlogic Meson GXBB SoC.
> > 
> > Any particular reason? We could just reuse the meson6 one since there
> > appear to be no code changes so far.
> 
> So Neil is essentially telling me they don't know whether there are any
> differences in the IP block, so a separate compatible string was chosen.
> 
> No objection from my side, but a general clarification from device tree
> maintainers when and when not to would be appreciated. (+ devicetree)

New chip, always define a new compatible. If you think they are the same 
or are close enough to function with the existing driver, then put both 
compatible strings in the DT.

Rob

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 0/2] spi: meson: Add Amlogic GXBB compatible Rob Herring <robh@kernel.org> - 2016-09-16 17:30 +0200

csiph-web