Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1485107

Re: [RFC PATCH 2/8] thread_info: allow custom in-task thread_info

Show all headers | View raw

> On Thu, Sep 15, 2016 at 11:37:47AM -0700, Andy Lutomirski wrote:
> > On Thu, Sep 15, 2016 at 6:49 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> > > Currently, task_struct is defined in <linux/sched.h>, which (indirectly)
> > > pulls in a number of low-level arch headers such as <asm/preempt.h>
> > > through a number of other headers. Thus, code and structures in these
> > > headers can't rely on the definition of task_struct. Some of these
> > > headers are necessary for the definition of task_struct, so moving
> > > task_struct into its own header is insufficient tio avoid circular
> > > includes.
> >
> > The flippant answer is to fix the headers, but I tried that myself and
> > gave up :(
>
> Agreed; likewise (though I gave up quicker, I suspect). :(
>
> Longer-term I'd still hope that we can do this.
>
> > But how about this slightly less duplicative alternative:
> >
> > struct thread_info {
> > #ifdef arch_thread_info
> >   struct arch_thread_info arch_ti;
> > #endif
> > };
>
> I'm happy to have an arch_thread_info.
>
> Just to check, what do you mean to happen with the flags field? Should
> that always be in the generic thread_info? e.g.
>
> struct thread_info {
>         u32 flags;
> #ifdef arch_thread_info
>         struct arch_thread_info arch_ti;
> #endif
> };

Exactly.  Possibly with a comment that using thread_struct should be
preferred and that arch_thread_info should be used only if some header
file requires access via current_thread_info() or task_thread_info().

--Andy

>
> Thanks,
> Mark,

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/8] arm64: move thread_info off of the task stack Mark Rutland <mark.rutland@arm.com> - 2016-09-15 15:50 +0200
  [RFC PATCH 8/8] arm64: split thread_info from task stack Mark Rutland <mark.rutland@arm.com> - 2016-09-15 16:00 +0200
  [RFC PATCH 5/8] arm64: assembler: introduce ldr_this_cpu Mark Rutland <mark.rutland@arm.com> - 2016-09-15 16:00 +0200
  [RFC PATCH 4/8] arm64: asm-offsets: remove unused definitions Mark Rutland <mark.rutland@arm.com> - 2016-09-15 16:00 +0200
  [RFC PATCH 1/8] thread_info: include <current.h> for THREAD_INFO_IN_TASK Mark Rutland <mark.rutland@arm.com> - 2016-09-15 16:00 +0200
  [RFC PATCH 3/8] arm64: thread_info remove stale items Mark Rutland <mark.rutland@arm.com> - 2016-09-15 16:00 +0200
  [RFC PATCH 7/8] arm64: move sp_el0 and tpidr_el1 into cpu_suspend_ctx Mark Rutland <mark.rutland@arm.com> - 2016-09-15 16:00 +0200
  [RFC PATCH 2/8] thread_info: allow custom in-task thread_info Mark Rutland <mark.rutland@arm.com> - 2016-09-15 16:00 +0200
    Re: [RFC PATCH 2/8] thread_info: allow custom in-task thread_info Andy Lutomirski <luto@amacapital.net> - 2016-09-15 20:40 +0200
      Re: [RFC PATCH 2/8] thread_info: allow custom in-task thread_info Mark Rutland <mark.rutland@arm.com> - 2016-09-16 12:40 +0200
        Re: [RFC PATCH 2/8] thread_info: allow custom in-task thread_info Andy Lutomirski <luto@amacapital.net> - 2016-09-16 17:20 +0200
          Re: [RFC PATCH 2/8] thread_info: allow custom in-task thread_info Mark Rutland <mark.rutland@arm.com> - 2016-09-19 12:50 +0200
          Re: [RFC PATCH 2/8] thread_info: allow custom in-task thread_info Mark Rutland <mark.rutland@arm.com> - 2016-09-21 12:30 +0200
            Re: [RFC PATCH 2/8] thread_info: allow custom in-task thread_info Andy Lutomirski <luto@amacapital.net> - 2016-09-23 00:30 +0200
  [RFC PATCH 6/8] arm64: traps: use task_struct instead of thread_info Mark Rutland <mark.rutland@arm.com> - 2016-09-15 16:00 +0200
  Re: [RFC PATCH 0/8] arm64: move thread_info off of the task stack Laura Abbott <labbott@redhat.com> - 2016-09-21 03:30 +0200
    Re: [RFC PATCH 0/8] arm64: move thread_info off of the task stack Mark Rutland <mark.rutland@arm.com> - 2016-09-21 12:40 +0200

csiph-web