Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1485006

Re: [PATCH 01/10] staging: slicoss: slic.h: add a macro IOMEM_GET_FIELDADDR to fix sparse warnings

Show all headers | View raw

On 09/16/2016 08:57 PM, Greg KH wrote:
> 
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
> 
> A: No.
> Q: Should I include quotations after my reply?
> 
> 
> http://daringfireball.net/2007/07/on_top
> 
> On Fri, Sep 16, 2016 at 06:41:38PM +0800, zerons wrote:
>> these marcos are used to get the value or address of a member of a `__iomem` structure.
>> GET_FIELDADDR is like &iomem_obj->field, and
>> GET_FIELD32 is iomem_obj->u32val, GET_FIELD64 is iomem_obj->u64val.
>>
>> If patch the .c file directly, the source gets into a mess.
> 
> But add the macro, and then use it, in the same patch, so we can verify
> that this macro really is doing what you think it is doing, and so that
> it is used at the same time (no need to add a macro that no one uses...
> 
> thanks,
> 
> greg k-h
> 

Again, sorry about the `top-posting`. I am still not familiar with these
things, thanks for reminding me, I will follow the rules and try my best
not to waste your time.

Ok, I will add the macro and use it to fix the warning in the same patch,
and resend the patches.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/10] staging: slicoss: fix different address space sparse warnings Peng Sun <sironhide0null@gmail.com> - 2016-09-14 05:10 +0200
  [PATCH 05/10] staging: slicoss: slicoss.c: fix different address space sparse warning Peng Sun <sironhide0null@gmail.com> - 2016-09-14 05:10 +0200
  [PATCH 01/10] staging: slicoss: slic.h: add a macro IOMEM_GET_FIELDADDR to fix sparse warnings Peng Sun <sironhide0null@gmail.com> - 2016-09-14 05:10 +0200
    Re: [PATCH 01/10] staging: slicoss: slic.h: add a macro  IOMEM_GET_FIELDADDR to fix sparse warnings Greg KH <gregkh@linuxfoundation.org> - 2016-09-16 10:00 +0200
    Re: [PATCH 01/10] staging: slicoss: slic.h: add a macro  IOMEM_GET_FIELDADDR to fix sparse warnings Greg KH <gregkh@linuxfoundation.org> - 2016-09-16 10:00 +0200
      Re: [PATCH 01/10] staging: slicoss: slic.h: add a macro  IOMEM_GET_FIELDADDR to fix sparse warnings zerons <sironhide0null@gmail.com> - 2016-09-16 12:50 +0200
        Re: [PATCH 01/10] staging: slicoss: slic.h: add a macro  IOMEM_GET_FIELDADDR to fix sparse warnings Greg KH <gregkh@linuxfoundation.org> - 2016-09-16 15:00 +0200
          Re: [PATCH 01/10] staging: slicoss: slic.h: add a macro  IOMEM_GET_FIELDADDR to fix sparse warnings zerons <sironhide0null@gmail.com> - 2016-09-16 16:00 +0200
  [PATCH 09/10] staging: slicoss: slicoss.c: fix different address space sparse warning Peng Sun <sironhide0null@gmail.com> - 2016-09-14 05:10 +0200
  [PATCH 03/10] staging: slicoss: slic.h: add a macro IOMEM_SET_FIELD32 to fix sparse warnings Peng Sun <sironhide0null@gmail.com> - 2016-09-14 05:10 +0200

csiph-web