Re: [PATCH v2] fs/dcache.c: avoid soft-lockup in dput()

From	Vaishali Thakkar <vaishali.thakkar@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] fs/dcache.c: avoid soft-lockup in dput()
Date	2016-09-16 15:00 +0200
Message-ID	<si0Ui-4PI-13@gated-at.bofh.it> (permalink)
References	<rMGIa-6js-19@gated-at.bofh.it> <shWdY-1I1-15@gated-at.bofh.it> <si0hz-4BJ-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On Friday 16 September 2016 05:40 PM, Al Viro wrote:
> On Fri, Sep 16, 2016 at 01:19:19PM +0530, Vaishali Thakkar wrote:
> 
>> Hi,
>>
>> Just a question regarding this change. As after this change
>> dput() is sleepable, is it still safe to use if under the
>> spinlock in the function d_prune_aliases?
> 
> It has always been sleepable and it wouldn't have been safe to use
> under spinlocks.  Which d_prune_aliases() does not do - __dentry_kill()
> is called with dentry, its parent and its inode (if present) all locked and
> it drops all those locks before returning.

Ah, I see. Alright. Thanks for the clarification.

> 

-- 
Vaishali

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] fs/dcache.c: avoid soft-lockup in dput() Vaishali Thakkar <vaishali.thakkar@oracle.com> - 2016-09-16 10:00 +0200
  Re: [PATCH v2] fs/dcache.c: avoid soft-lockup in dput() Al Viro <viro@ZenIV.linux.org.uk> - 2016-09-16 14:20 +0200
    Re: [PATCH v2] fs/dcache.c: avoid soft-lockup in dput() Vaishali Thakkar <vaishali.thakkar@oracle.com> - 2016-09-16 15:00 +0200

csiph-web