Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1483773

Re: [PATCH] checkpatch: Minimize checkpatch induced patches...

Show all headers | View raw

On Wed, Sep 14, 2016 at 07:56:55PM +0200, Christian Borntraeger wrote:
> On 09/14/2016 07:51 PM, Joe Perches wrote:
> > checkpatch can be a useful tool for patches.
> > 
> > It can be a much more controversial tool when used on files with the
> > -f option for style and whitespace changes for code that is relatively
> > stable, obsolete, or for maintained by specific individuals.
> > 
> > o By default, allow checkpatch to be used with the -f|--file option
> >   for files in drivers/staging/
> > o Add an undocumented --force command line option to be used together
> >   with the -f|--file option to scan any file
> > 
> > Signed-off-by: Joe Perches <joe@perches.com>
> > cc: Greg KH <greg@kroah.com>
> > cc: Jonathan Corbet <corbet@lwn.net>
> > cc: Josh Triplett <josh@joshtriplett.org>
> > cc: Christian Borntraeger <borntraeger@de.ibm.com>
> > cc: Theodore Ts'o <tytso@mit.edu>
> 
> This will certainly help to reduce the noise. On the other hand I remember Linus
> saying something along the line that he does not like the -f parameter (and he
> prefers to set this automatically). So while I like the approach I am not happy
> enough to ack right now - still looking for a better alternative :-/

This seems entirely compatible with autodetection.  If checkpatch
detects that it runs on a file rather than a patch, it can assume -f.
It can then apply this same logic to reject that if 1) in a kernel tree
and 2) running on a non-staging file and 3) not passed --force.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] checkpatch: Minimize checkpatch induced patches... Christian Borntraeger <borntraeger@de.ibm.com> - 2016-09-14 20:00 +0200
  Re: [PATCH] checkpatch: Minimize checkpatch induced patches... Joe Perches <joe@perches.com> - 2016-09-14 20:10 +0200
    Re: [PATCH] checkpatch: Minimize checkpatch induced patches... Christian Borntraeger <borntraeger@de.ibm.com> - 2016-09-14 20:20 +0200
      Re: [PATCH] checkpatch: Minimize checkpatch induced patches... Christian Borntraeger <borntraeger@de.ibm.com> - 2016-09-14 20:30 +0200
      Re: [PATCH] checkpatch: Minimize checkpatch induced patches... Joe Perches <joe@perches.com> - 2016-09-14 20:30 +0200
      Re: [PATCH] checkpatch: Minimize checkpatch induced patches... Greg KH <greg@kroah.com> - 2016-09-14 20:40 +0200
        Re: [PATCH] checkpatch: Minimize checkpatch induced patches... Christian Borntraeger <borntraeger@de.ibm.com> - 2016-09-14 21:00 +0200
          Re: [PATCH] checkpatch: Minimize checkpatch induced patches... Joe Perches <joe@perches.com> - 2016-09-14 21:20 +0200
        Re: [PATCH] checkpatch: Minimize checkpatch induced patches... Christian Borntraeger <borntraeger@de.ibm.com> - 2016-09-18 21:40 +0200
  Re: [PATCH] checkpatch: Minimize checkpatch induced patches... Josh Triplett <josh@joshtriplett.org> - 2016-09-15 02:00 +0200
    Re: [PATCH] checkpatch: Minimize checkpatch induced patches... Josh Triplett <josh@joshtriplett.org> - 2016-09-15 02:10 +0200
    Re: [PATCH] checkpatch: Minimize checkpatch induced patches... Joe Perches <joe@perches.com> - 2016-09-15 02:10 +0200

csiph-web