Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1483465

Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture

Show all headers | View raw

On 2016/09/14 10:52AM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Sep 14, 2016 at 02:58:10PM +0530, Naveen N. Rao escreveu:
> > On 2016/09/12 06:15PM, Arnaldo Carvalho de Melo wrote:
> > > Em Mon, Sep 12, 2016 at 04:07:42PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > So, please take a look at my perf/core branch, I applied 1/3 and 3/3,
> > > but took a different path for 2/3, now it builds for all systems I have
> > > containers for:
> 
> > This still fails for me on ppc64. Perhaps we should guard 
> > P_MMAP_FLAG(32BIT) and potentially others with a #ifdef, which was 
> > earlier reverted by commit 256763b0 ("perf trace beauty mmap: Add more 
> > conditional defines")?
> 
> Humm, yeah, we have to find a way to make it clear that some flags are
> not present in all arches, I'll think about the solution Wang came up
> with, i.e. having it defined to zero on arches where it is not
> supported, which at first sounds ugly :-\
> 
> One thing related to this, but for future work, is to be able to support
> doing a ' perf trace record'  on x86_64 and then doing a 'perf trace -i
> perf.data' with the resulting file, i.e. cross-platform syscall arg
> beautifying, i.e. a cross-arch strace.
> 
> Right now we use audit lib to at least map the syscall ids using, IIRC,
> the header env stuff, but we need to go to the syscall args as well.
> Future work, sure.
> 
> And yeah, I'll try and cross-build audit-lib for my powerpc cross build
> containers, so that I can catch this bug before applying these patches
> and make sure things like this get caught in the future.

Thanks, Arnaldo!
Though, if it is too much work, I don't mind reporting/trying to fix the 
odd build failure. I've setup daily builds to catch any such issues.

Regards,
Naveen

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] tools include: Add uapi mman.h for each architecture Wang Nan <wangnan0@huawei.com> - 2016-09-12 15:00 +0200
  Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-12 21:10 +0200
    Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-12 23:20 +0200
      Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture "Wangnan (F)" <wangnan0@huawei.com> - 2016-09-13 08:40 +0200
      Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2016-09-14 11:30 +0200
        Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture "Wangnan (F)" <wangnan0@huawei.com> - 2016-09-14 11:40 +0200
          Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2016-09-14 12:10 +0200
            Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture "Wangnan (F)" <wangnan0@huawei.com> - 2016-09-14 12:30 +0200
              Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2016-09-14 12:50 +0200
                Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture "Wangnan (F)" <wangnan0@huawei.com> - 2016-09-14 13:00 +0200
        Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-14 16:00 +0200
          Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2016-09-14 18:40 +0200
            Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-14 19:10 +0200
              Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2016-09-15 17:00 +0200
  [tip:perf/core] tools include: Add uapi mman.h for each  architecture tip-bot for Wang Nan <tipbot@zytor.com> - 2016-09-20 23:40 +0200

csiph-web