Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1483241

Re: [PATCH V2 4/4] ARM64 LPC: support earlycon for UART connected to LPC

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject Re: [PATCH V2 4/4] ARM64 LPC: support earlycon for UART connected to LPC
Date 2016-09-14 14:40 +0200
Message-ID <shhDQ-SQ-17@gated-at.bofh.it> (permalink)
References <seKVH-db-1@gated-at.bofh.it> <sf5ns-53y-9@gated-at.bofh.it> <shgy5-dA-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wednesday, September 14, 2016 7:26:22 PM CEST zhichang wrote:
> 
> > 
> >> Hip06 LPC uart need two base addresses for earlycon.
> >> 2. the IO type is mmio to introduce a memory base address to access LPC register file. But the real uart
> >> IO type is UPIO_PORT. This is spcial...
> > 
> > This sounds like a deficiency in the of_setup_earlycon() function,
> > which can only handle MMIO addresses, and won't actually
> > be able to understand nodes without a "ranges" property like
> > you have here.
> > 
> Yes.
> The current of_setup_earlycon only support MMIO and the first reg property must be memory.
> 
> We can not support our LPC uart without any new code.
> But we can implement a private earlycon setup function and register
> it to the __earlycon_table, things will be ok.

I still think you should adapt of_setup_earlycon instead to handle IORESOURCE_IO
registers.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

Re: [PATCH V2 4/4] ARM64 LPC: support earlycon for UART connected to  LPC zhichang <zhichang.yuan02@gmail.com> - 2016-09-14 13:30 +0200
  Re: [PATCH V2 4/4] ARM64 LPC: support earlycon for UART connected to LPC Arnd Bergmann <arnd@arndb.de> - 2016-09-14 14:40 +0200

csiph-web