Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1483154

[PATCH] mmc: omap_hsmmc: Initialize dma_slave_config to avoid random data

Show all headers | View raw

It is wrong to not initialize the dma_slave_config struct as the DMAengine
driver might look at non initialized (random data) fields and tries to
interpret it.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
Hi,

would it be possible to send this patch for 4.8? I have omap-dma DMAengine
driver changes pending, but they break the MMC/SD because of the uninitialized
fields in dma_slave_config.

Thanks,
Peter

 drivers/mmc/host/omap_hsmmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 24ebc9a8de89..0a5640156159 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -1409,7 +1409,7 @@ static int omap_hsmmc_pre_dma_transfer(struct omap_hsmmc_host *host,
 static int omap_hsmmc_setup_dma_transfer(struct omap_hsmmc_host *host,
 					struct mmc_request *req)
 {
-	struct dma_slave_config cfg;
+	struct dma_slave_config cfg = {};
 	struct dma_async_tx_descriptor *tx;
 	int ret = 0, i;
 	struct mmc_data *data = req->data;
--
2.10.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mmc: omap_hsmmc: Initialize dma_slave_config to avoid random data Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-09-14 12:20 +0200
  Re: [PATCH] mmc: omap_hsmmc: Initialize dma_slave_config to avoid random data Arnd Bergmann <arnd@arndb.de> - 2016-09-14 12:30 +0200
    Re: [PATCH] mmc: omap_hsmmc: Initialize dma_slave_config to avoid  random data Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-09-14 13:00 +0200
    Re: [PATCH] mmc: omap_hsmmc: Initialize dma_slave_config to avoid  random data Ulf Hansson <ulf.hansson@linaro.org> - 2016-09-14 13:00 +0200

csiph-web