[PATCH] leds: Only remove trigger if one is actually configured.

From	Daniel Romell <danielromell@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] leds: Only remove trigger if one is actually configured.
Date	2016-09-14 11:30 +0200
Message-ID	<sheFX-7x3-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

In led_trigger_remove(), check if there is a trigger
configured before calling led_trigger_set(). This will
prevent some unnecessary work, and more importantly stop
sending uevent change events when no change has in fact
occurred.

Signed-off-by: Daniel Romell <daro@hms.se>
---
 drivers/leds/led-triggers.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c
index 59d6a3e..28c7a66 100644
--- a/drivers/leds/led-triggers.c
+++ b/drivers/leds/led-triggers.c
@@ -147,7 +147,8 @@ EXPORT_SYMBOL_GPL(led_trigger_set);
 void led_trigger_remove(struct led_classdev *led_cdev)
 {
 	down_write(&led_cdev->trigger_lock);
-	led_trigger_set(led_cdev, NULL);
+	if (led_cdev->trigger)
+		led_trigger_set(led_cdev, NULL);
 	up_write(&led_cdev->trigger_lock);
 }
 EXPORT_SYMBOL_GPL(led_trigger_remove);
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] leds: Only remove trigger if one is actually configured. Daniel Romell <danielromell@gmail.com> - 2016-09-14 11:30 +0200
  Re: [PATCH] leds: Only remove trigger if one is actually configured. Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-09-15 13:50 +0200
    Re: [PATCH] leds: Only remove trigger if one is actually configured. Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-09-20 09:40 +0200
      Re: [PATCH] leds: Only remove trigger if one is actually configured. Daniel Romell <Daro@hms.se> - 2016-09-20 21:30 +0200

csiph-web