Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1482919

Re: [PATCH v14 15/15] selftests/powerpc: Fix a build issue

From Cyril Bur <cyrilbur@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v14 15/15] selftests/powerpc: Fix a build issue
Date 2016-09-14 07:00 +0200
Message-ID <shasG-448-15@gated-at.bofh.it> (permalink)
References <sgu0p-fL-3@gated-at.bofh.it> <sgu0p-fL-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, 2016-09-12 at 15:33 +0800, wei.guo.simon@gmail.com wrote:
> From: Anshuman Khandual <khandual@linux.vnet.ibm.com>
> 
> Fixes the following build failure -
> 
> cp_abort.c:90:3: error: ‘for’ loop initial declarations are only
> allowed in C99 or C11 mode
>    for (int i = 0; i < NUM_LOOPS; i++) {
>    ^
> cp_abort.c:90:3: note: use option -std=c99, -std=gnu99, -std=c11 or
> -std=gnu11 to compile your code
> cp_abort.c:97:3: error: ‘for’ loop initial declarations are only
> allowed in C99 or C11 mode
>    for (int i = 0; i < NUM_LOOPS; i++) {
> 
> Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
> Signed-off-by: Simon Guo <wei.guo.simon@gmail.com>

Reviewed-by: Cyril Bur <cyrilbur@gmail.com>

> ---
>  tools/testing/selftests/powerpc/context_switch/cp_abort.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git
> a/tools/testing/selftests/powerpc/context_switch/cp_abort.c
> b/tools/testing/selftests/powerpc/context_switch/cp_abort.c
> index 5a5b55a..1ce7dce 100644
> --- a/tools/testing/selftests/powerpc/context_switch/cp_abort.c
> +++ b/tools/testing/selftests/powerpc/context_switch/cp_abort.c
> @@ -67,7 +67,7 @@ int test_cp_abort(void)
>  	/* 128 bytes for a full cache line */
>  	char buf[128] __cacheline_aligned;
>  	cpu_set_t cpuset;
> -	int fd1[2], fd2[2], pid;
> +	int fd1[2], fd2[2], pid, i;
>  	char c;
>  
>  	/* only run this test on a P9 or later */
> @@ -87,14 +87,14 @@ int test_cp_abort(void)
>  	FAIL_IF(pid < 0);
>  
>  	if (!pid) {
> -		for (int i = 0; i < NUM_LOOPS; i++) {
> +		for (i = 0; i < NUM_LOOPS; i++) {
>  			FAIL_IF((write(fd1[WRITE_FD], &c, 1)) != 1);
>  			FAIL_IF((read(fd2[READ_FD], &c, 1)) != 1);
>  			/* A paste succeeds if CR0 EQ bit is set */
>  			FAIL_IF(paste(buf) & 0x20000000);
>  		}
>  	} else {
> -		for (int i = 0; i < NUM_LOOPS; i++) {
> +		for (i = 0; i < NUM_LOOPS; i++) {
>  			FAIL_IF((read(fd1[READ_FD], &c, 1)) != 1);
>  			copy(buf);
>  			FAIL_IF((write(fd2[WRITE_FD], &c, 1) != 1));

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v14 00/15] selftests/powerpc: Add ptrace tests for ppc registers wei.guo.simon@gmail.com - 2016-09-12 09:40 +0200
  [PATCH v14 08/15] selftests/powerpc: Add ptrace tests for TAR, PPR, DSCR in TM wei.guo.simon@gmail.com - 2016-09-12 09:40 +0200
  [PATCH v14 04/15] selftests/powerpc: Add ptrace tests for GPR/FPR registers wei.guo.simon@gmail.com - 2016-09-12 09:40 +0200
    Re: [PATCH v14 04/15] selftests/powerpc: Add ptrace tests for  GPR/FPR registers Cyril Bur <cyrilbur@gmail.com> - 2016-09-14 07:00 +0200
  [PATCH v14 15/15] selftests/powerpc: Fix a build issue wei.guo.simon@gmail.com - 2016-09-12 09:40 +0200
    Re: [PATCH v14 15/15] selftests/powerpc: Fix a build issue Cyril Bur <cyrilbur@gmail.com> - 2016-09-14 07:00 +0200
  [PATCH v14 05/15] selftests/powerpc: Add ptrace tests for GPR/FPR registers in TM wei.guo.simon@gmail.com - 2016-09-12 09:40 +0200
    Re: [PATCH v14 05/15] selftests/powerpc: Add ptrace tests for  GPR/FPR registers in TM Cyril Bur <cyrilbur@gmail.com> - 2016-09-14 07:00 +0200
  [PATCH v14 12/15] selftests/powerpc: Add ptrace tests for VSX, VMX registers in suspended TM wei.guo.simon@gmail.com - 2016-09-12 09:40 +0200
  [PATCH v14 01/15] selftests/powerpc: Add more SPR numbers, TM & VMX instructions to 'reg.h' wei.guo.simon@gmail.com - 2016-09-12 09:40 +0200
    Re: [PATCH v14 01/15] selftests/powerpc: Add more SPR numbers, TM &  VMX instructions to 'reg.h' Cyril Bur <cyrilbur@gmail.com> - 2016-09-14 06:50 +0200
  [PATCH v14 02/15] selftests/powerpc: Use the new SPRN_DSCR_PRIV definiton wei.guo.simon@gmail.com - 2016-09-12 09:40 +0200
  [PATCH v14 06/15] selftests/powerpc: Add ptrace tests for GPR/FPR registers in suspended TM wei.guo.simon@gmail.com - 2016-09-12 09:40 +0200
  [PATCH v14 07/15] selftests/powerpc: Add ptrace tests for TAR, PPR, DSCR registers wei.guo.simon@gmail.com - 2016-09-12 09:40 +0200
    Re: [PATCH v14 07/15] selftests/powerpc: Add ptrace tests for TAR,  PPR, DSCR registers Cyril Bur <cyrilbur@gmail.com> - 2016-09-14 07:00 +0200

csiph-web