Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1484834

Re: [PATCH 0/6] x86/dumpstack: replace dump_trace() with a new unwinder

Show all headers | View raw

* Josh Poimboeuf <jpoimboe@redhat.com> wrote:

> The last version was posted as part of a much larger patch set:
> 
>   https://lkml.kernel.org/r/cover.1471525031.git.jpoimboe@redhat.com
> 
> People complained about the set being too big, so it was split up into
> more digestible pieces.  All the prerequisite patches for the unwinder
> have now been merged.
> 
> See patch 1/6 for the background and justification for this change.
> 
> Josh Poimboeuf (6):
>   x86/unwind: add new unwind interface and implementations
>   perf/x86: convert perf_callchain_kernel() to use the new unwinder
>   x86/stacktrace: convert save_stack_trace_*() to use the new unwinder
>   oprofile/x86: convert x86_backtrace() to use the new unwinder
>   x86/dumpstack: convert show_trace_log_lvl() to use the new unwinder
>   x86/dumpstack: remove dump_trace() and related callbacks
> 
>  arch/x86/events/core.c            |  33 +++-----
>  arch/x86/include/asm/stacktrace.h |  46 +---------
>  arch/x86/include/asm/unwind.h     |  74 ++++++++++++++++
>  arch/x86/kernel/Makefile          |   6 ++
>  arch/x86/kernel/dumpstack.c       | 174 +++++++++++++++++---------------------
>  arch/x86/kernel/dumpstack_32.c    |  44 +---------
>  arch/x86/kernel/dumpstack_64.c    |  78 +----------------
>  arch/x86/kernel/stacktrace.c      |  74 +++++++---------
>  arch/x86/kernel/unwind_frame.c    |  93 ++++++++++++++++++++
>  arch/x86/kernel/unwind_guess.c    |  43 ++++++++++
>  arch/x86/oprofile/backtrace.c     |  39 ++++-----
>  11 files changed, 362 insertions(+), 342 deletions(-)
>  create mode 100644 arch/x86/include/asm/unwind.h
>  create mode 100644 arch/x86/kernel/unwind_frame.c
>  create mode 100644 arch/x86/kernel/unwind_guess.c

Looks good to me, but could you please rebase it on top of very latestest -tip, 
which has these bits from Andy included:

  1959a60182f4 x86/dumpstack: Pin the target stack when dumping it
  cb76c9398240 x86/dumpstack: Add get_stack_info() interface

... which create new conflicts with your series.

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] x86/dumpstack: replace dump_trace() with a new unwinder Josh Poimboeuf <jpoimboe@redhat.com> - 2016-09-15 18:00 +0200
  [PATCH 3/6] x86/stacktrace: convert save_stack_trace_*() to use the new unwinder Josh Poimboeuf <jpoimboe@redhat.com> - 2016-09-15 18:00 +0200
  [PATCH 1/6] x86/unwind: add new unwind interface and implementations Josh Poimboeuf <jpoimboe@redhat.com> - 2016-09-15 18:00 +0200
  [PATCH 2/6] perf/x86: convert perf_callchain_kernel() to use the new unwinder Josh Poimboeuf <jpoimboe@redhat.com> - 2016-09-15 18:00 +0200
  [PATCH 5/6] x86/dumpstack: convert show_trace_log_lvl() to use the new unwinder Josh Poimboeuf <jpoimboe@redhat.com> - 2016-09-15 18:00 +0200
  [PATCH 4/6] oprofile/x86: convert x86_backtrace() to use the new unwinder Josh Poimboeuf <jpoimboe@redhat.com> - 2016-09-15 18:00 +0200
  Re: [PATCH 0/6] x86/dumpstack: replace dump_trace() with a new  unwinder Ingo Molnar <mingo@kernel.org> - 2016-09-16 11:20 +0200

csiph-web