Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1484779
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 1/3] nvme/scsi: Remove power management support |
| Date | 2016-09-16 10:40 +0200 |
| Message-ID | <shWQG-2fE-3@gated-at.bofh.it> (permalink) |
| References | <shTSN-k4-5@gated-at.bofh.it> <shTSN-k4-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Sep 15, 2016 at 10:24:19PM -0700, Andy Lutomirski wrote: > As far as I can tell, there is basically nothing correct about this > code. It misinterprets npss (off-by-one). It hardcodes a bunch of > power states, which is nonsense, because they're all just indices > into a table that software needs to parse. It completely ignores > the distinction between operational and non-operational states. > And, until 4.8, if all of the above magically succeeded, it would > dereference a NULL pointer and OOPS. > > Since this code appears to be useless, just delete it. Yes, please! Acked-by: Christoph Hellwig <hch@lst.de>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 0/3] nvme power saving Andy Lutomirski <luto@kernel.org> - 2016-09-16 07:30 +0200
[PATCH v3 3/3] nvme: Enable autonomous power state transitions Andy Lutomirski <luto@kernel.org> - 2016-09-16 07:30 +0200
Re: [PATCH v3 3/3] nvme: Enable autonomous power state transitions Christoph Hellwig <hch@lst.de> - 2016-09-16 10:50 +0200
Re: [PATCH v3 3/3] nvme: Enable autonomous power state transitions Andy Lutomirski <luto@amacapital.net> - 2016-09-16 17:20 +0200
Re: [PATCH v3 3/3] nvme: Enable autonomous power state transitions Christoph Hellwig <hch@lst.de> - 2016-09-16 19:00 +0200
Re: [PATCH v3 3/3] nvme: Enable autonomous power state transitions Keith Busch <keith.busch@intel.com> - 2016-09-16 17:30 +0200
[PATCH v3 1/3] nvme/scsi: Remove power management support Andy Lutomirski <luto@kernel.org> - 2016-09-16 07:30 +0200
Re: [PATCH v3 1/3] nvme/scsi: Remove power management support Christoph Hellwig <hch@lst.de> - 2016-09-16 10:40 +0200
Re: [PATCH v3 1/3] nvme/scsi: Remove power management support Christoph Hellwig <hch@lst.de> - 2016-09-16 16:30 +0200
Re: [PATCH v3 1/3] nvme/scsi: Remove power management support Johannes Thumshirn <jthumshirn@suse.de> - 2016-09-19 10:00 +0200
Re: [PATCH v3 1/3] nvme/scsi: Remove power management support Keith Busch <keith.busch@intel.com> - 2016-09-16 16:30 +0200
Re: [PATCH v3 1/3] nvme/scsi: Remove power management support J Freyensee <james_p_freyensee@linux.intel.com> - 2016-09-17 01:40 +0200
csiph-web