Re: [RFC PATCH v2 19/20] x86: Access the setup data through debugfs un-encrypted

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v2 19/20] x86: Access the setup data through debugfs un-encrypted
Date	2016-09-16 09:20 +0200
Message-ID	<shVBf-1un-15@gated-at.bofh.it> (permalink)
References	(1 earlier) <sgCKl-5RJ-19@gated-at.bofh.it> <sgCKl-5RJ-17@gated-at.bofh.it> <shjPk-27U-21@gated-at.bofh.it> <shjPk-27U-19@gated-at.bofh.it> <shVBf-1un-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Sep 15, 2016 at 12:08:04PM -0500, Tom Lendacky wrote:
> The problem is that this physical address does not contain the
> encryption bit, and even if it did, it wouldn't matter.  The __va()
> define creates a virtual address that will be mapped as encrypted given
> the current approach (which is how I found this).  It's only ioremap()
> that would create a mapping without the encryption attribute and since
> this is unencrypted data it needs to be access accordingly.

I see. So since this is not obvious, please add this explanation to maybe

Documentation/x86/amd-memory-encryption.txt

and point in there to an example or so so.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH v2 19/20] x86: Access the setup data through debugfs  un-encrypted Borislav Petkov <bp@alien8.de> - 2016-09-12 19:00 +0200
  Re: [RFC PATCH v2 19/20] x86: Access the setup data through debugfs  un-encrypted Borislav Petkov <bp@alien8.de> - 2016-09-14 17:00 +0200
    Re: [RFC PATCH v2 19/20] x86: Access the setup data through debugfs  un-encrypted Borislav Petkov <bp@alien8.de> - 2016-09-16 09:20 +0200

csiph-web