Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1484461

Re: [PATCH 1/2] staging: sm750fb: fix line length coding style issues in ddk750_chip.c

Show all headers | View raw

On Mon, Sep 12, 2016 at 01:16:35PM +0200, Greg KH wrote:
> On Sun, Sep 04, 2016 at 09:03:27PM +0300, Moshe Green wrote:
> > Fix multiple line length warnings found by the checkpatch.pl tool
> > in ddk750_chip.c.
> > 
> > Signed-off-by: Moshe Green <mgmoshes@gmail.com>
> > ---
> >  drivers/staging/sm750fb/ddk750_chip.c | 18 ++++++++++++------
> >  1 file changed, 12 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> > index c1356bb..76aaeaa 100644
> > --- a/drivers/staging/sm750fb/ddk750_chip.c
> > +++ b/drivers/staging/sm750fb/ddk750_chip.c
> > @@ -71,7 +71,7 @@ static void setChipClock(unsigned int frequency)
> >  		pll.clockType = MXCLK_PLL;
> >  
> >  		/*
> > -		* Call calcPllValue() to fill up the other fields for PLL structure.
> > +		* Call calcPllValue() to fill the other fields of PLL structure.
> >  		* Sometime, the chip cannot set up the exact clock required by User.
> >  		* Return value from calcPllValue() gives the actual possible clock.
> 
> You only changed one sentance here, please fix the whole block.
> 
> thanks,
> 
> greg k-h


Will do.
Thanks

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] staging: sm750fb: fix line length coding style  issues in ddk750_chip.c Greg KH <gregkh@linuxfoundation.org> - 2016-09-12 13:20 +0200
  Re: [PATCH 1/2] staging: sm750fb: fix line length coding style  issues in ddk750_chip.c Moshe Green <mgmoshes@gmail.com> - 2016-09-15 21:00 +0200

csiph-web