Re: [PATCH v2 2/3] mm, dax: add VM_DAX flag for DAX VMAs

From	"Darrick J. Wong" <darrick.wong@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/3] mm, dax: add VM_DAX flag for DAX VMAs
Date	2016-09-15 19:20 +0200
Message-ID	<shIul-1sh-7@gated-at.bofh.it> (permalink)
References	<shyOl-3Aa-5@gated-at.bofh.it> <shyOm-3Aa-17@gated-at.bofh.it> <shAds-4BB-21@gated-at.bofh.it> <shIkF-1p0-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Sep 15, 2016 at 10:01:03AM -0700, Dan Williams wrote:
> On Thu, Sep 15, 2016 at 1:26 AM, Christoph Hellwig <hch@lst.de> wrote:
> > On Wed, Sep 14, 2016 at 11:54:38PM -0700, Dan Williams wrote:
> >> The DAX property, page cache bypass, of a VMA is only detectable via the
> >> vma_is_dax() helper to check the S_DAX inode flag.  However, this is
> >> only available internal to the kernel and is a property that userspace
> >> applications would like to interrogate.
> >
> > They have absolutely no business knowing such an implementation detail.
> 
> Hasn't that train already left the station with FS_XFLAG_DAX?

Seeing as FS_IOC_FSGETXATTR is a "generic" ioctl now, why not just
implement it for all the DAX fses and block devices?  Aside from xflags,
the other fields are probably all zero for non-xfs (aside from project
quota id I guess).

(Yeah, sort of awkward, I know...)

--D

> The other problem with hiding the DAX property is that it turns out to
> not be a transparent acceleration feature.  See xfs/086 xfs/088
> xfs/089 xfs/091 which fail with DAX and, as far as I understand, it is
> due to the fact that DAX disallows delayed allocation behavior.
> 
> If behavior changes I think we should indicate that to userspace and
> VM_DAX is certainly more useful to userspace than some of the other vm
> internals we already export in those flags.
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

Thread

[PATCH v2 0/3] mm,  dax: export dax capabilities and mapping size info to userspace Dan Williams <dan.j.williams@intel.com> - 2016-09-15 09:00 +0200
  [PATCH v2 1/3] mm, dax: add VM_SYNC flag for device-dax VMAs Dan Williams <dan.j.williams@intel.com> - 2016-09-15 09:00 +0200
  [PATCH v2 2/3] mm, dax: add VM_DAX flag for DAX VMAs Dan Williams <dan.j.williams@intel.com> - 2016-09-15 09:00 +0200
    Re: [PATCH v2 2/3] mm, dax: add VM_DAX flag for DAX VMAs Christoph Hellwig <hch@lst.de> - 2016-09-15 10:30 +0200
      Re: [PATCH v2 2/3] mm, dax: add VM_DAX flag for DAX VMAs Dan Williams <dan.j.williams@intel.com> - 2016-09-15 19:10 +0200
        Re: [PATCH v2 2/3] mm, dax: add VM_DAX flag for DAX VMAs "Darrick J. Wong" <darrick.wong@oracle.com> - 2016-09-15 19:20 +0200
          Re: [PATCH v2 2/3] mm, dax: add VM_DAX flag for DAX VMAs Dan Williams <dan.j.williams@intel.com> - 2016-09-15 19:50 +0200
        Re: [PATCH v2 2/3] mm, dax: add VM_DAX flag for DAX VMAs Dave Chinner <david@fromorbit.com> - 2016-09-16 01:10 +0200
          Re: [PATCH v2 2/3] mm, dax: add VM_DAX flag for DAX VMAs Dan Williams <dan.j.williams@intel.com> - 2016-09-16 01:20 +0200
          Re: [PATCH v2 2/3] mm, dax: add VM_DAX flag for DAX VMAs Dan Williams <dan.j.williams@intel.com> - 2016-09-16 02:20 +0200
            Re: [PATCH v2 2/3] mm, dax: add VM_DAX flag for DAX VMAs Dave Chinner <david@fromorbit.com> - 2016-09-16 03:30 +0200
              Re: [PATCH v2 2/3] mm, dax: add VM_DAX flag for DAX VMAs Dan Williams <dan.j.williams@intel.com> - 2016-09-16 04:10 +0200
                Re: [PATCH v2 2/3] mm, dax: add VM_DAX flag for DAX VMAs Dan Williams <dan.j.williams@intel.com> - 2016-09-16 05:50 +0200
                Re: [PATCH v2 2/3] mm, dax: add VM_DAX flag for DAX VMAs Dave Chinner <david@fromorbit.com> - 2016-09-16 07:40 +0200
                Re: [PATCH v2 2/3] mm, dax: add VM_DAX flag for DAX VMAs Dan Williams <dan.j.williams@intel.com> - 2016-09-16 12:50 +0200

csiph-web