Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1484433

Re: [PATCH 4/4] input: serio: Replace timeval by timespec64

Show all headers | View raw

On Tue, Sep 13, 2016 at 8:13 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tuesday, September 13, 2016 7:10:05 AM CEST Deepa Dinamani wrote:
>> struct timeval is not y2038 safe.
>> All references to timeval will be deleted from the
>> kernel to make it y2038 safe.
>> Replace its uses by y2038 safe struct timespec64.
>>
>> The timestamps changed here only keep track of delta
>> times. These timestamps are also internal to kernel.
>> Hence, monotonic times are sufficient here.
>> The unit of the delta times is also changed in certain
>> cases to nanoseconds rather than microseconds. This is
>> in line with timespec64 which keeps time in nanoseconds.
>>
>> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
>>
>
> Looks all correct to me,
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> I think it could be done a little nicer using ktime_get()
> instead of ktime_get_ts64(), but probably nobody cares with
> this driver.

I tried to keep the processing same as timeval.
This could be changed to ktime_get() if that is preferred.

-Deepa

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/4] input: serio: Replace timeval by timespec64 Deepa Dinamani <deepa.kernel@gmail.com> - 2016-09-13 16:20 +0200
  Re: [PATCH 4/4] input: serio: Replace timeval by timespec64 Arnd Bergmann <arnd@arndb.de> - 2016-09-13 17:20 +0200
    Re: [PATCH 4/4] input: serio: Replace timeval by timespec64 Deepa Dinamani <deepa.kernel@gmail.com> - 2016-09-15 19:30 +0200

csiph-web