Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1484380
| From | Vinod Koul <vinod.koul@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ARM: s3c24xx: Add dma_slave_map for s3c2440 devices |
| Date | 2016-09-15 18:20 +0200 |
| Message-ID | <shHyh-SP-15@gated-at.bofh.it> (permalink) |
| References | <shAQ9-54k-9@gated-at.bofh.it> <shngd-4l1-19@gated-at.bofh.it> <shAQ9-54k-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Sep 15, 2016 at 11:05:12AM +0200, Sylwester Nawrocki wrote:
> On 09/14/2016 08:29 PM, Sam Van Den Berge wrote:
> > +static const struct dma_slave_map s3c2440_dma_slave_map[] = {
> ...
> > + { "3c2440-sdi", "rx", (void *)DMACH_SDI },
> > + { "3c2440-sdi", "tx", (void *)DMACH_SDI },
>
> The device names seem misspelled here, and looking at what
> drivers/mmc/host/s3cmci.c driver does we need just a single common
> entry for rx and tx
>
> { "s3c2440-sdi", "rx-tx", (void *)DMACH_SDI },
>
> With this fixed feel free to add
And please change the title to dmaengine and NOT arm... I was about ti skip
this!
--
~Vinod
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] ARM: s3c24xx: Add dma_slave_map for s3c2440 devices Sam Van Den Berge <sam.van.den.berge@telenet.be> - 2016-09-14 20:40 +0200
Re: [PATCH] ARM: s3c24xx: Add dma_slave_map for s3c2440 devices Sylwester Nawrocki <s.nawrocki@samsung.com> - 2016-09-15 11:10 +0200
Re: [PATCH] ARM: s3c24xx: Add dma_slave_map for s3c2440 devices Vinod Koul <vinod.koul@intel.com> - 2016-09-15 18:20 +0200
Re: [PATCH] ARM: s3c24xx: Add dma_slave_map for s3c2440 devices Arnd Bergmann <arnd@arndb.de> - 2016-09-15 11:30 +0200
csiph-web