Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1484359

Re: [PATCH 2/6 linux-next] ext4: remove unneeded test in ext4_alloc_file_blocks()

From Theodore Ts'o <tytso@mit.edu>
Newsgroups linux.kernel
Subject Re: [PATCH 2/6 linux-next] ext4: remove unneeded test in ext4_alloc_file_blocks()
Date 2016-09-15 18:00 +0200
Message-ID <shHeW-rB-27@gated-at.bofh.it> (permalink)
References <s9MEN-7el-13@gated-at.bofh.it> <s9MEN-7el-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Aug 24, 2016 at 10:03:16PM +0200, Fabian Frederick wrote:
> ext4_alloc_file_blocks() is called from ext4_zero_range() and
> ext4_fallocate() both already testing EXT4_INODE_EXTENTS
> We can call ext_depth(inode) unconditionnally.
> 
> Signed-off-by: Fabian Frederick <fabf@skynet.be>

Applied, although I also added a BUG_ON() check to make sure
ext4_alloc_file_blocks() won't get called with an indirect-mapped
inode in the future.

				- Ted

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH 2/6 linux-next] ext4: remove unneeded test in  ext4_alloc_file_blocks() Theodore Ts'o <tytso@mit.edu> - 2016-09-15 18:00 +0200

csiph-web