Re: [PATCH] staging: rts5208: Comparisons should place the constant on the right side of the test

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: rts5208: Comparisons should place the constant on the right side of the test
Date	2016-09-15 17:00 +0200
Message-ID	<shGiR-8jb-7@gated-at.bofh.it> (permalink)
References	<shGiR-8jb-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Sep 15, 2016 at 04:29:54PM +0200, Sergio Paracuellos wrote:
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
>  drivers/staging/rts5208/rtsx_card.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rts5208/rtsx_card.c b/drivers/staging/rts5208/rtsx_card.c
> index 9a5cd63..551e3064 100644
> --- a/drivers/staging/rts5208/rtsx_card.c
> +++ b/drivers/staging/rts5208/rtsx_card.c
> @@ -645,7 +645,7 @@ int switch_ssc_clock(struct rtsx_chip *chip, int clk)
>  	dev_dbg(rtsx_dev(chip), "Switch SSC clock to %dMHz (cur_clk = %d)\n",
>  		clk, chip->cur_clk);
>  
> -	if ((clk <= 2) || (N > max_N)) {
> +	if ((clk <= 2) || (max_N < N)) {

Where is the constant?

The original code looks fine to me...

Also, I can't take patches where there is no changelog text, sorry.

greg k-h

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] staging: rts5208: Comparisons should place the constant  on the right side of the test Greg KH <gregkh@linuxfoundation.org> - 2016-09-15 17:00 +0200
  Re: [PATCH] staging: rts5208: Comparisons should place the constant  on the right side of the test Sergio Paracuellos <sergio.paracuellos@gmail.com> - 2016-09-15 19:30 +0200
    Re: [PATCH] staging: rts5208: Comparisons should place the constant  on the right side of the test Joe Perches <joe@perches.com> - 2016-09-15 19:40 +0200
    Re: [PATCH] staging: rts5208: Comparisons should place the constant  on the right side of the test Dan Carpenter <dan.carpenter@oracle.com> - 2016-09-16 13:30 +0200

csiph-web