Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1484315

Re: [RFC PATCH v2 11/11] irqchip: mbigen: promote mbigen init

Show all headers | View raw

On 14/09/16 15:21, Hanjun Guo wrote:
> From: Hanjun Guo <hanjun.guo@linaro.org>
> 
> mbigen is an irqchip and it needs to be probed before
> devices, same logic is used for SMMU and etc., let's
> use arch_initcall instead of platform init for mbigen.
> 
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ma Jun <majun258@huawei.com>
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> ---
>  drivers/irqchip/irq-mbigen.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c
> index ca6add1..3a33de6 100644
> --- a/drivers/irqchip/irq-mbigen.c
> +++ b/drivers/irqchip/irq-mbigen.c
> @@ -374,7 +374,11 @@ static struct platform_driver mbigen_platform_driver = {
>  	.probe			= mbigen_device_probe,
>  };
>  
> -module_platform_driver(mbigen_platform_driver);
> +static __init int mbigen_init(void)
> +{
> +	return platform_driver_register(&mbigen_platform_driver);
> +}
> +arch_initcall(mbigen_init);
>  
>  MODULE_AUTHOR("Jun Ma <majun258@huawei.com>");
>  MODULE_AUTHOR("Yun Wu <wuyun.wu@huawei.com>");
> 

I've already NACKed such a patch in the past, and I will carry on
NACKing it until all the other avenues (like properly tracking device
dependencies) have been explored and have been proven not to be fit for
purpose.

Rafael had proposed something around this subject last year, and I've
been repeatedly advising you to work with him and others to make it
happen. You can choose to ignore this advise, but that doesn't make this
patch an acceptable approach.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH v2 11/11] irqchip: mbigen: promote mbigen init Hanjun Guo <guohanjun@huawei.com> - 2016-09-14 16:30 +0200
  Re: [RFC PATCH v2 11/11] irqchip: mbigen: promote mbigen init Marc Zyngier <marc.zyngier@arm.com> - 2016-09-15 17:30 +0200
    Re: [RFC PATCH v2 11/11] irqchip: mbigen: promote mbigen init Hanjun Guo <hanjun.guo@linaro.org> - 2016-09-19 12:00 +0200
      Re: [RFC PATCH v2 11/11] irqchip: mbigen: promote mbigen init Marc Zyngier <marc.zyngier@arm.com> - 2016-09-19 12:20 +0200
        Re: [RFC PATCH v2 11/11] irqchip: mbigen: promote mbigen init Hanjun Guo <guohanjun@huawei.com> - 2016-09-20 04:50 +0200

csiph-web