Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1484309

[PATCH 3/4] drm/sun4i: dotclock: Allow divider = 127

Show all headers | View raw

The dot clock divider is 7 bits wide, and the divider range is 1 ~ 127,
or 6 ~ 127 if phase offsets are used. The 0 register value also
represents a divider of 1 or bypass.

Make the end condition of the for loop inclusive of 127 in the
round_rate callback.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 drivers/gpu/drm/sun4i/sun4i_dotclock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/sun4i/sun4i_dotclock.c b/drivers/gpu/drm/sun4i/sun4i_dotclock.c
index 1b6c2253192e..3eb99784f371 100644
--- a/drivers/gpu/drm/sun4i/sun4i_dotclock.c
+++ b/drivers/gpu/drm/sun4i/sun4i_dotclock.c
@@ -77,7 +77,7 @@ static long sun4i_dclk_round_rate(struct clk_hw *hw, unsigned long rate,
 	u8 best_div = 1;
 	int i;
 
-	for (i = 6; i < 127; i++) {
+	for (i = 6; i <= 127; i++) {
 		unsigned long ideal = rate * i;
 		unsigned long rounded;
 
-- 
2.9.3

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] drm/sun4i: rgb and dotclock misc fixes and improvements Chen-Yu Tsai <wens@csie.org> - 2016-09-15 17:20 +0200
  [PATCH 1/4] drm/sun4i: rgb: Declare RGB encoder and connector as MIPI DPI Chen-Yu Tsai <wens@csie.org> - 2016-09-15 17:20 +0200
    Re: [PATCH 1/4] drm/sun4i: rgb: Declare RGB encoder and connector as  MIPI DPI Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-18 21:20 +0200
      Re: [PATCH 1/4] drm/sun4i: rgb: Declare RGB encoder and connector as  MIPI DPI Chen-Yu Tsai <wens@csie.org> - 2016-09-19 17:30 +0200
  [PATCH 2/4] drm/sun4i: dotclock: Fix clock rate read back calcation Chen-Yu Tsai <wens@csie.org> - 2016-09-15 17:20 +0200
    Re: [PATCH 2/4] drm/sun4i: dotclock: Fix clock rate read back  calcation Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-18 21:20 +0200
  [PATCH 4/4] drm/sun4i: dotclock: Round to closest clock rate Chen-Yu Tsai <wens@csie.org> - 2016-09-15 17:20 +0200
    Re: [PATCH 4/4] drm/sun4i: dotclock: Round to closest clock rate Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-18 21:20 +0200
      Re: [PATCH 4/4] drm/sun4i: dotclock: Round to closest clock rate Chen-Yu Tsai <wens@csie.org> - 2016-09-19 17:40 +0200
        Re: [PATCH 4/4] drm/sun4i: dotclock: Round to closest clock rate Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-20 17:50 +0200
    Re: [PATCH 4/4] drm/sun4i: dotclock: Round to closest clock rate Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-20 17:50 +0200
  [PATCH 3/4] drm/sun4i: dotclock: Allow divider = 127 Chen-Yu Tsai <wens@csie.org> - 2016-09-15 17:20 +0200
    Re: [PATCH 3/4] drm/sun4i: dotclock: Allow divider = 127 Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-18 21:20 +0200

csiph-web