Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1484177

Re: [PATCH] of/platform: Initialise dev->fwnode appropriately

Show all headers | View raw

On Wed, Sep 14, 2016 at 04:01:24PM +0100, Robin Murphy wrote:
> Whilst we're some of the way towards a universal firmware property
> interface, drivers which deal with both OF and ACPI probing end up
> having to do things like this:
> 
>     dev->of_node ? &dev->of_node->fwnode : dev->fwnode
> 
> This seems unnecessary, when the OF code could instead simply fill in
> the device's fwnode when binding the of_node, and let the drivers use
> dev->fwnode either way. Let's give it a go and see what falls out.
> 
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
>  drivers/of/platform.c | 2 ++
>  1 file changed, 2 insertions(+)

I've applied this, but what about non-platform devices such as i2c?

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] of/platform: Initialise dev->fwnode appropriately Robin Murphy <robin.murphy@arm.com> - 2016-09-14 17:10 +0200
  Re: [PATCH] of/platform: Initialise dev->fwnode appropriately Rob Herring <robh@kernel.org> - 2016-09-15 15:40 +0200
    Re: [PATCH] of/platform: Initialise dev->fwnode appropriately Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-09-16 13:20 +0200
    Re: [PATCH] of/platform: Initialise dev->fwnode appropriately Robin Murphy <robin.murphy@arm.com> - 2016-09-16 14:10 +0200

csiph-web