Re: [PATCH for-next 18/20] IB/hns: Update the rq head when modify qp state

From	Leon Romanovsky <leon@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH for-next 18/20] IB/hns: Update the rq head when modify qp state
Date	2016-09-15 12:20 +0200
Message-ID	<shBVU-5HB-19@gated-at.bofh.it> (permalink)
References	<sfr4B-1xy-3@gated-at.bofh.it> <sfr4C-1xy-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Sep 09, 2016 at 06:30:49PM +0800, Salil Mehta wrote:
> From: Lijun Ou <oulijun@huawei.com>
>
> The rq head in qpc was zero will miss the rq wqes which
> have be sent, so here we should take the real value.
>
> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> Reviewed-by:  Wei Hu (Xavier) <xavier.huwei@huawei.com>
> Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
> ---
>  drivers/infiniband/hw/hns/hns_roce_hw_v1.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> index bdd9453..7a61d7e 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> @@ -2266,7 +2266,8 @@ static int hns_roce_v1_m_qp(struct ib_qp *ibqp, const struct ib_qp_attr *attr,
>
>  		roce_set_field(context->qpc_bytes_68,
>  			       QP_CONTEXT_QPC_BYTES_68_RQ_HEAD_M,
> -			       QP_CONTEXT_QPC_BYTES_68_RQ_HEAD_S, 0);
> +			       QP_CONTEXT_QPC_BYTES_68_RQ_HEAD_S,
> +			       hr_qp->rq.head);

Are you sure that it should be list_head and not value?

>  		roce_set_field(context->qpc_bytes_68,
>  			       QP_CONTEXT_QPC_BYTES_68_RQ_CUR_INDEX_M,
>  			       QP_CONTEXT_QPC_BYTES_68_RQ_CUR_INDEX_S, 0);
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH for-next 18/20] IB/hns: Update the rq head when modify qp  state Leon Romanovsky <leon@kernel.org> - 2016-09-15 12:20 +0200
  RE: [PATCH for-next 18/20] IB/hns: Update the rq head when modify  qp state Salil Mehta <salil.mehta@huawei.com> - 2016-09-20 19:00 +0200
    Re: [PATCH for-next 18/20] IB/hns: Update the rq head when modify qp  state Leon Romanovsky <leon@kernel.org> - 2016-09-20 19:10 +0200
      RE: [PATCH for-next 18/20] IB/hns: Update the rq head when modify  qp state Salil Mehta <salil.mehta@huawei.com> - 2016-09-20 19:50 +0200

csiph-web