Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1482772

Re: [PATCH 3/4] input: Deprecate real timestamps beyond year 2106

Show all headers | View raw

On Tuesday, September 13, 2016 1:10:06 PM CEST Deepa Dinamani wrote:
> struct timeval is not y2038 safe.
> All usage of timeval in the kernel will be replaced by
> y2038 safe structures.
> 
> struct input_event maintains time for each input event.
> Real time timestamps are not ideal for input as this
> time can go backwards as noted in the patch a80b83b7b8
> by John Stultz. Hence, having the input_event.time fields
> only big enough for monotonic and boot times are
> sufficient.
> 
> Leave the original input_event as is. This is to maintain
> backward compatibility with existing userspace interfaces
> that use input_event.
> Introduce a new replacement struct raw_input_event.
> This replaces timeval with struct input_timeval. This structure
> maintains time in __kernel_ulong_t or compat_ulong_t to allow
> for architectures to override types as in the case of x32.
> 
> The change requires any userspace utilities reading or writing
> from event nodes to update their reading format to match
> raw_input_event.The changes to the popular libraries will be
> posted along with the kernel changes.
> The driver version is also updated to reflect the change in
> event format.
> 
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> 

Acked-by: Arnd Bergmann <arnd@arndb.de>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] Make input drivers y2038 safe Deepa Dinamani <deepa.kernel@gmail.com> - 2016-09-13 16:20 +0200
  [PATCH 3/4] input: Deprecate real timestamps beyond year 2106 Deepa Dinamani <deepa.kernel@gmail.com> - 2016-09-13 16:20 +0200
    Re: [PATCH 3/4] input: Deprecate real timestamps beyond year 2106 Arnd Bergmann <arnd@arndb.de> - 2016-09-13 17:00 +0200
    Re: [PATCH 3/4] input: Deprecate real timestamps beyond year 2106 kbuild test robot <lkp@intel.com> - 2016-09-13 18:10 +0200
      Re: [PATCH 3/4] input: Deprecate real timestamps beyond year 2106 Deepa Dinamani <deepa.kernel@gmail.com> - 2016-09-13 18:40 +0200
        [PATCH 3/4] input: Deprecate real timestamps beyond year 2106 Deepa Dinamani <deepa.kernel@gmail.com> - 2016-09-13 22:20 +0200
          Re: [PATCH 3/4] input: Deprecate real timestamps beyond year 2106 Arnd Bergmann <arnd@arndb.de> - 2016-09-13 22:50 +0200

csiph-web