Re: [PATCH v2 10/33] x86/intel_rdt: Implement scheduling support for Intel RDT

From	Nilay Vaish <nilayvaish@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 10/33] x86/intel_rdt: Implement scheduling support for Intel RDT
Date	2016-09-13 20:00 +0200
Message-ID	<sh09X-57b-27@gated-at.bofh.it> (permalink)
References	<sf1tv-2mB-5@gated-at.bofh.it> <sf1Dc-2F3-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 8 September 2016 at 04:57, Fenghua Yu <fenghua.yu@intel.com> wrote:
> diff --git a/arch/x86/kernel/cpu/intel_rdt.c b/arch/x86/kernel/cpu/intel_rdt.c
> index 9cf3a7d..9f30492 100644
> --- a/arch/x86/kernel/cpu/intel_rdt.c
> +++ b/arch/x86/kernel/cpu/intel_rdt.c
> @@ -21,6 +21,8 @@
>   */
>  #include <linux/slab.h>
>  #include <linux/err.h>
> +#include <linux/sched.h>
> +#include <asm/pqr_common.h>
>  #include <asm/intel_rdt.h>
>
>  /*
> @@ -41,12 +43,28 @@ static cpumask_t rdt_cpumask;
>   */
>  static cpumask_t tmp_cpumask;
>  static DEFINE_MUTEX(rdtgroup_mutex);
> +struct static_key __read_mostly rdt_enable_key = STATIC_KEY_INIT_FALSE;

I had pointed this for the previous version of the patch as well.  You
should use DEFINE_STATIC_KEY_FALSE(rdt_enable_key), instead of what
you have here.

--
Nilay

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 10/33] x86/intel_rdt: Implement scheduling support for  Intel RDT Nilay Vaish <nilayvaish@gmail.com> - 2016-09-13 20:00 +0200

csiph-web