Re: [PATCH] ARM: dma-mapping: add in missing white space in error message text

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Robin Murphy <robin.murphy@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: dma-mapping: add in missing white space in error message text
Date	Mon, 12 Sep 2016 15:10:02 +0200
Message-ID	<sgz9M-3JB-49@gated-at.bofh.it> (permalink)
References	<sgz06-3qM-15@gated-at.bofh.it>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	35
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org
X-Original-Date	Mon, 12 Sep 2016 14:06:09 +0100
X-Original-Message-ID	<db1758f8-0335-6661-e797-b2021682a087@arm.com>
X-Original-References	<20160912125212.32739-1-colin.king@canonical.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1481258

Show key headers only | View raw

On 12/09/16 13:52, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> A dev_warn message spans two lines and the literal string is missing
> a white space between words. Add the white space.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  arch/arm/common/dmabounce.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
> index 3012816..f47767b 100644
> --- a/arch/arm/common/dmabounce.c
> +++ b/arch/arm/common/dmabounce.c
> @@ -547,7 +547,7 @@ void dmabounce_unregister_dev(struct device *dev)
>  
>  	if (!device_info) {
>  		dev_warn(dev,
> -			 "Never registered with dmabounce but attempting"
> +			 "Never registered with dmabounce but attempting "
>  			 "to unregister!\n");

Per Documentation/CodingStyle, better to put the whole thing onto one
line so that, say, "git grep 'attempting to unregister'" doesn't leave
one scratching ones head in confusion.

Of course, even better would be to get rid of the whole thing and
convert ARM to use SWIOTLB, but hey, one thing at a time ;)

Robin.

>  		return;
>  	}
>

Thread

[PATCH] ARM: dma-mapping: add in missing white space in error message text Colin King <colin.king@canonical.com> - 2016-09-12 15:00 +0200
  Re: [PATCH] ARM: dma-mapping: add in missing white space in error  message text Robin Murphy <robin.murphy@arm.com> - 2016-09-12 15:10 +0200
    Re: [PATCH] ARM: dma-mapping: add in missing white space in error  message text Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-09-12 16:40 +0200
      Re: [PATCH] ARM: dma-mapping: add in missing white space in error  message text Colin Ian King <colin.king@canonical.com> - 2016-09-12 17:00 +0200

csiph-web