Re: [PATCH] watchdog: rt2880_wdt: Remove assignment of dev pointer

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] watchdog: rt2880_wdt: Remove assignment of dev pointer
Date	Mon, 12 Sep 2016 15:10:02 +0200
Message-ID	<sgz9M-3JB-41@gated-at.bofh.it> (permalink)
References	<sgvSy-1oS-1@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=roeck-us.net; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:Cc:References:To:Subject; bh=O/9V38Q7feI5+RinMyddWD+Ups85vN/o33gPMItBgLI=; b=brf0NMMEs1fh3HGnkc4T89ppE8 FaG7Vcb/H1XD0DTs/jClCWZAwJRwIq3PjG0JO9A0OU6oyo9AV2Z7likSCNADpX39aHTEY4gZGniBe /USZQ0IvXu3Jl9duBFJ2zGuslNKLJrHQR5uee1owg79vERLt2Tg2vxWOMSt5OCpqvquj2fuBn3fc8 fXiMa5Ty/paGR0tbG1lneRPIn1rtyAGx+yDkZzCtWLzdqgV041mAPaL5U6bFDkBxgWVykHPpEPeL+ UVIyKeGGUCT2QoYpuXjU0ODcXDdKD+M0QMTEkRZo9kPDqB+zn59eEqkB6xd9cb9x4jlMCJnyLn2TC uID4yq+w==;
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding	8bit
X-Authenticated_Sender	linux@roeck-us.net
X-Outgoing-Spam-Status	No, score=-1.0
X-Antiabuse	This header was added to track abuse, please include it with any abuse report
X-Antiabuse	Primary Hostname - bh-25.webhostbox.net
X-Antiabuse	Original Domain - vger.kernel.org
X-Antiabuse	Originator/Caller UID/GID - [47 12] / [47 12]
X-Antiabuse	Sender Address Domain - roeck-us.net
X-Get-Message-Sender-Via	bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net
X-Authenticated-Sender	bh-25.webhostbox.net: linux@roeck-us.net
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	44
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org
X-Original-Date	Mon, 12 Sep 2016 06:01:06 -0700
X-Original-Message-ID	<d836fe83-8daa-9e17-4eca-41331c480a24@roeck-us.net>
X-Original-References	<1473672913-10484-1-git-send-email-matt.redfearn@imgtec.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1481254

Show key headers only | View raw

On 09/12/2016 02:35 AM, Matt Redfearn wrote:
> Commit 0254e953537c ("watchdog: Drop pointer to watchdog device from
> struct watchdog_device") removed the dev pointer from struct
> watchdog_device, but this driver was still assigning it, leading to a
> compilation error:
>
> drivers/watchdog/rt2880_wdt.c: In function ‘rt288x_wdt_probe’:
> drivers/watchdog/rt2880_wdt.c:161:16: error: ‘struct watchdog_device’
> has no member named ‘dev’
>   rt288x_wdt_dev.dev = &pdev->dev;
>                 ^
> scripts/Makefile.build:289: recipe for target
> 'drivers/watchdog/rt2880_wdt.o' failed
>
> Fix this by removing the assignment.
>
> Fixes: 0254e953537c

Fixes: 0254e953537c ("watchdog: Drop pointer to watchdog device ...")

> Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>

Cc: stable@vger.kernel.org # v4.5+

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>
>  drivers/watchdog/rt2880_wdt.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/rt2880_wdt.c b/drivers/watchdog/rt2880_wdt.c
> index 1967919ae743..14b4fd428fff 100644
> --- a/drivers/watchdog/rt2880_wdt.c
> +++ b/drivers/watchdog/rt2880_wdt.c
> @@ -158,7 +158,6 @@ static int rt288x_wdt_probe(struct platform_device *pdev)
>
>  	rt288x_wdt_freq = clk_get_rate(rt288x_wdt_clk) / RALINK_WDT_PRESCALE;
>
> -	rt288x_wdt_dev.dev = &pdev->dev;
>  	rt288x_wdt_dev.bootstatus = rt288x_wdt_bootcause();
>  	rt288x_wdt_dev.max_timeout = (0xfffful / rt288x_wdt_freq);
>  	rt288x_wdt_dev.parent = &pdev->dev;
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] watchdog: rt2880_wdt: Remove assignment of dev pointer Matt Redfearn <matt.redfearn@imgtec.com> - 2016-09-12 11:40 +0200
  Re: [PATCH] watchdog: rt2880_wdt: Remove assignment of dev pointer Guenter Roeck <linux@roeck-us.net> - 2016-09-12 15:10 +0200

csiph-web