Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1481069

[PATCH 7/9] clocksource/drivers/timer-atmel-pit: Remove uselesss WARN_ON_ONCE

Show all headers | View raw

From: Alexandre Belloni <alexandre.belloni@free-electrons.com>

IRQ handlers are running with IRQ disabled for a while, remove wrong
comment and useless test.

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/timer-atmel-pit.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c
index da7e6d4..91cf047 100644
--- a/drivers/clocksource/timer-atmel-pit.c
+++ b/drivers/clocksource/timer-atmel-pit.c
@@ -149,12 +149,6 @@ static irqreturn_t at91sam926x_pit_interrupt(int irq, void *dev_id)
 {
 	struct pit_data *data = dev_id;
 
-	/*
-	 * irqs should be disabled here, but as the irq is shared they are only
-	 * guaranteed to be off if the timer irq is registered first.
-	 */
-	WARN_ON_ONCE(!irqs_disabled());
-
 	/* The PIT interrupt may be disabled, and is shared */
 	if (clockevent_state_periodic(&data->clkevt) &&
 	    (pit_read(data->base, AT91_PIT_SR) & AT91_PIT_PITS)) {
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PULL] clockevents for 4.9 Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-09-12 11:20 +0200
  [PATCH 7/9] clocksource/drivers/timer-atmel-pit: Remove uselesss WARN_ON_ONCE Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-09-12 11:20 +0200
  [PATCH 1/9] clocksource/drivers/moxart: Refactor enable/disable Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-09-12 11:20 +0200
    [PATCH 5/9] clocksource/drivers/moxart: Replace panic by pr_err Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-09-12 11:20 +0200
    [PATCH 9/9] clocksource/drivers/oxnas: Add OX820 compatible Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-09-12 11:20 +0200
    [PATCH 8/9] clocksource/drivers/timer-atmel-pit: Simplify IRQ handler Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-09-12 11:20 +0200
    [PATCH 3/9] clocksource/drivers/moxart: Add Aspeed support Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-09-12 11:20 +0200
    [PATCH 2/9] clocksource/drivers/moxart: Use struct to hold state Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-09-12 11:20 +0200
    [PATCH 4/9] clocksource/drivers/moxart: Replace setup_irq by request_irq Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-09-12 11:20 +0200

csiph-web