Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1481072

Re: [PATCH] staging: ks7010: mark symbols static where possible

Show all headers | View raw

On Sun, Sep 04, 2016 at 02:38:39PM +0800, Baoyou Xie wrote:
> We get 2 warnings when building kernel with W=1:
> drivers/staging/ks7010/ks_hostif.c:72:6: warning: no previous prototype for 'ks_wlan_hw_wakeup_task' [-Wmissing-prototypes]
> drivers/staging/ks7010/ks_hostif.c:1508:6: warning: no previous prototype for 'hostif_infrastructure_set2_request' [-Wmissing-prototypes]
> 
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
>  drivers/staging/ks7010/ks_hostif.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This patch is already in my tree :(

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] staging: ks7010: mark symbols static where possible Greg KH <gregkh@linuxfoundation.org> - 2016-09-12 11:20 +0200

csiph-web