Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1481030

Re: [PATCH -next] drm/tilcdc: Fix non static symbol warning

Show all headers | View raw

On 09/10/16 15:32, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fixes the following sparse warning:
> 
> drivers/gpu/drm/tilcdc/tilcdc_drv.c:64:5: warning:
>  symbol 'tilcdc_atomic_check' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

I'll pick this up.

Thanks,
Jyri

> ---
>  drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 4405e4b..dc58770 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -61,8 +61,8 @@ static void tilcdc_fb_output_poll_changed(struct drm_device *dev)
>  	drm_fbdev_cma_hotplug_event(priv->fbdev);
>  }
>  
> -int tilcdc_atomic_check(struct drm_device *dev,
> -			struct drm_atomic_state *state)
> +static int tilcdc_atomic_check(struct drm_device *dev,
> +			       struct drm_atomic_state *state)
>  {
>  	int ret;
>  
> 
> 
> 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH -next] drm/tilcdc: Fix non static symbol warning Wei Yongjun <weiyj.lk@gmail.com> - 2016-09-10 14:40 +0200
  Re: [PATCH -next] drm/tilcdc: Fix non static symbol warning Jyri Sarha <jsarha@ti.com> - 2016-09-12 10:30 +0200

csiph-web