Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1480883
| Path | csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Joel Stanley <joel@jms.id.au> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] clocksource/drivers/moxart: Replace setup_irq by request_irq |
| Date | Mon, 12 Sep 2016 03:50:02 +0200 |
| Message-ID | <sgoxI-5f9-9@gated-at.bofh.it> (permalink) |
| References | <sf81Y-6tT-17@gated-at.bofh.it> |
| X-Original-To | Daniel Lezcano <daniel.lezcano@linaro.org> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=CZAHmLQuJmrHRYORaBKCjg9ufu23DIKllQ1hWLFK5vY=; b=GmI980ESclFHCKxNPoooUOctsL0YJsYURibW1Ye0Xh09SwlGdpjMa/3FSlc7ylltJg vuu0ih8jmXjCfpY5uP+I0eaPwOwqsYJWGjNXx58fcpOICPGmgpU9Jv9gOoFmXlU4cMTf P9sc2gKeVsNUSybBWQ0m0lY0bOFsUztl6T6v82fymu+jF6J9N9nAxo2KaFkRHEFpRaBz taWk8GGmdtR8V9iEOOtvPdVkW8YRjAR5LGIZ7r5qET8bPwRCy+x1LEFO3FIISzQli4Cq 93fI5aVKQALWX2uBiylPLBSkrfs/w9GokWKlcMlL/bPb3oF1hXMXKxvcoTSlEONO6bNW Xc7Q== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=CZAHmLQuJmrHRYORaBKCjg9ufu23DIKllQ1hWLFK5vY=; b=IKrr9yh6QyHRWTK8dfwtO25neXMAYEHYoFTfr8W6hSN0BWZOj/ecdHDTu1J7zUzDYd FfPerBCx66Lqst3mFDPfN5/VDz/GWfcVjis9G4Vu6MT+SEhU2Ung3uOf0xgdNq3IBIyo J7FBorRUA7cu1NuoHA2M7vkUIpz6lyBIQRremdm8L25/XCS5fvsm58nF75PGYbUQOE37 XFrB0U8q2fX9OCGVUa+EdIktz+xmKxVUBlRSwP1etQkE8NGCYDzURk5wywX5MI+rCp0O HhxMOAkZHYmpq6xzxcuQWCcJFvgoIX8mGNG7GgejrxLGcor3weKeVjRND5oX3F6oktvx LlCA== |
| X-Gm-Message-State | AE9vXwMnk9VhpZ8PEoLMNq3D7wW8jiZcDM8Aae332QEW/aSn+j3sYmQy2FA2DQvVGP3bK2EBmN1qhsOPJPsRbw== |
| X-Received | by 10.31.148.147 with SMTP id w141mr10189638vkd.1.1473644805429; Sun, 11 Sep 2016 18:46:45 -0700 (PDT) |
| MIME-Version | 1.0 |
| X-Google-Sender-Auth | RSQtpyTUpsucD02gOtsug-P7Jak |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 50 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org |
| X-Original-Date | Mon, 12 Sep 2016 11:16:24 +0930 |
| X-Original-Message-ID | <CACPK8Xe-WBkA1_+3z5UBYS6up=0O7JsVNDPKhEMzX7Hrq0AWog@mail.gmail.com> |
| X-Original-References | <1473343090-29208-1-git-send-email-daniel.lezcano@linaro.org> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1480883 |
Show key headers only | View raw
On Thu, Sep 8, 2016 at 11:28 PM, Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
> Save memory space and line of code by replacing setup_irq by request_irq.
Thanks. I also gave it a spin on our hardware to be sure.
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Joel Stanley <joel@jms.id.au>
> ---
> drivers/clocksource/moxart_timer.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clocksource/moxart_timer.c b/drivers/clocksource/moxart_timer.c
> index ad2bead9..cba25b7 100644
> --- a/drivers/clocksource/moxart_timer.c
> +++ b/drivers/clocksource/moxart_timer.c
> @@ -79,7 +79,6 @@ struct moxart_timer {
> unsigned int t1_enable_val;
> unsigned int count_per_tick;
> struct clock_event_device clkevt;
> - struct irqaction act;
> };
>
> static inline struct moxart_timer *to_moxart(struct clock_event_device *evt)
> @@ -201,10 +200,6 @@ static int __init moxart_timer_init(struct device_node *node)
> timer->clkevt.set_next_event = moxart_clkevt_next_event;
> timer->clkevt.cpumask = cpumask_of(0);
> timer->clkevt.irq = irq;
> - timer->act.name = node->name;
> - timer->act.flags = IRQF_TIMER;
> - timer->act.handler = moxart_timer_interrupt;
> - timer->act.dev_id = &timer->clkevt;
>
> ret = clocksource_mmio_init(timer->base + TIMER2_BASE + REG_COUNT,
> "moxart_timer", pclk, 200, 32,
> @@ -214,7 +209,8 @@ static int __init moxart_timer_init(struct device_node *node)
> return ret;
> }
>
> - ret = setup_irq(irq, &timer->act);
> + ret = request_irq(irq, moxart_timer_interrupt, IRQF_TIMER,
> + node->name, &timer->clkevt);
> if (ret) {
> pr_err("%s: setup_irq failed\n", node->full_name);
> return ret;
> --
> 1.9.1
>
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH 1/2] clocksource/drivers/moxart: Replace setup_irq by request_irq Joel Stanley <joel@jms.id.au> - 2016-09-12 03:50 +0200
csiph-web